unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: rms@gnu.org
Cc: Andreas Schwab <schwab@suse.de>, emacs-devel@gnu.org
Subject: Re: Change in process.c
Date: Tue, 27 Mar 2007 17:16:05 -0400	[thread overview]
Message-ID: <87ejna5qwa.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1HWElL-0007IK-1E@fencepost.gnu.org> (Richard Stallman's message of "Tue\, 27 Mar 2007 12\:43\:11 -0400")

Richard Stallman <rms@gnu.org> writes:

> I don't mind making a change to fix this,
> but it must not do a full-second sleep before the first wait3,
> and it must not use usleep since that is obsolete.

Does this version work?

*** emacs/src/process.c.~1.508.~	2007-03-27 16:47:03.000000000 -0400
--- emacs/src/process.c	2007-03-27 17:13:31.000000000 -0400
***************
*** 6500,6516 ****
  #define WUNTRACED 0
  #endif /* no WUNTRACED */
        /* Keep trying to get a status until we get a definitive result.  */
!       do
          {
  	  /* For some reason, this sleep() prevents Emacs from sending
               loadavg to 5-8(!) for ~10 seconds.
               See http://thread.gmane.org/gmane.emacs.devel/67722 or
               http://www.google.com/search?q=busyloop+in+sigchld_handler */
!           usleep (1000);
  	  errno = 0;
  	  pid = wait3 (&w, WNOHANG | WUNTRACED, 0);
  	}
-       while (pid < 0 && errno == EINTR);
  
        if (pid <= 0)
  	{
--- 6500,6518 ----
  #define WUNTRACED 0
  #endif /* no WUNTRACED */
        /* Keep trying to get a status until we get a definitive result.  */
! 
!       errno = 0;
!       pid = wait3 (&w, WNOHANG | WUNTRACED, 0);
!       while (pid < 0 && errno == EINTR)
          {
  	  /* For some reason, this sleep() prevents Emacs from sending
               loadavg to 5-8(!) for ~10 seconds.
               See http://thread.gmane.org/gmane.emacs.devel/67722 or
               http://www.google.com/search?q=busyloop+in+sigchld_handler */
!           sleep (1);
  	  errno = 0;
  	  pid = wait3 (&w, WNOHANG | WUNTRACED, 0);
  	}
  
        if (pid <= 0)
  	{

  reply	other threads:[~2007-03-27 21:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26 23:13 Change in process.c Richard Stallman
2007-03-27  3:06 ` Sam Steingold
2007-03-27  9:55   ` Andreas Schwab
2007-03-27 10:33     ` Nick Roberts
2007-03-27 16:43     ` Richard Stallman
2007-03-27 21:16       ` Chong Yidong [this message]
2007-03-27 22:11         ` Nick Roberts
2007-03-28 14:02           ` Sam Steingold
2007-03-28 21:09             ` Nick Roberts
2007-03-28 13:55         ` Sam Steingold
2007-03-28 14:13           ` Andreas Schwab
2007-03-28 15:25             ` Sam Steingold
2007-03-28 19:08               ` Jan Djärv
2007-03-28 20:57                 ` Kim F. Storm
2007-03-29  6:12                   ` Jan Djärv
2007-03-29 21:25                     ` Kim F. Storm
2007-03-28 15:11           ` Chong Yidong
2007-03-28 16:09         ` Richard Stallman
2007-03-29 13:57 ` Randal L. Schwartz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ejna5qwa.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).