From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: A bug in tetris Date: Mon, 20 Aug 2007 12:37:06 +0200 Message-ID: <87ejhyjxv1.fsf@kfs-lx.testafd.dk> References: <7dbe73ed0708190822o5431b2b7m437a1d5073afe55@mail.gmail.com> <87hcmvp3bn.fsf@kfs-lx.testafd.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1187606262 17038 80.91.229.12 (20 Aug 2007 10:37:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2007 10:37:42 +0000 (UTC) Cc: sdl.web@gmail.com, emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 12:37:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IN4db-0004eg-Na for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2007 12:37:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IN4dc-0000fp-5H for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2007 06:37:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IN4dN-0000c9-W5 for emacs-devel@gnu.org; Mon, 20 Aug 2007 06:37:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IN4dJ-0000bD-MY for emacs-devel@gnu.org; Mon, 20 Aug 2007 06:37:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IN4dI-0000ao-Iw for emacs-devel@gnu.org; Mon, 20 Aug 2007 06:37:17 -0400 Original-Received: from mail-relay.sonofon.dk ([212.88.64.25]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1IN4dG-0005tx-4h for emacs-devel@gnu.org; Mon, 20 Aug 2007 06:37:14 -0400 Original-Received: (qmail 9991 invoked from network); 20 Aug 2007 10:37:07 -0000 Original-Received: from unknown (HELO kfs-lx.testafd.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 20 Aug 2007 10:37:07 -0000 In-Reply-To: (Kenichi Handa's message of "Mon\, 20 Aug 2007 10\:30\:00 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-Detected-Kernel: FreeBSD 4.6-4.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76821 Archived-At: Kenichi Handa writes: > In article <87hcmvp3bn.fsf@kfs-lx.testafd.dk>, storm@cua.dk (Kim F. Storm) writes: > >> Leo writes: >> > I am still seeing the same problem with this patch. The default value of >> > line-spacing is nil which means no extra space. > > >> Maybe the newlines in the gamegrid must be marked to not increase >> line height by its own: > >> (propertize "\n" 'line-height t) > > Isn't it better to make that the default behaviour if a line > is not empty? It would have been an incompatible change, so I didn't do that. However, I think there might be good reasons to do just that, and reverse the meaning of the line-height == t to mean _do_ include the newline of a non-empty line in the height calculation. If we want to do that, I think _NOW_ is the only time to do it. The feature is new in 22.1, so probably nobody has used it outside the code in emacs itself, so a change should be made before releasing 22.2. (remember to change the uses already in the code). -- Kim F. Storm http://www.cua.dk