unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Welsh Duggan <md5i@cs.cmu.edu>
To: rms@gnu.org
Cc: Drew Adams <drew.adams@oracle.com>, emacs-devel@gnu.org
Subject: Re: Simplification of faces
Date: Sun, 07 Oct 2007 14:29:30 -0400	[thread overview]
Message-ID: <87ejg63hit.fsf@maru.md5i.com> (raw)
In-Reply-To: <E1Icpn0-0008PC-3r@fencepost.gnu.org> (Richard Stallman's message of "Tue\, 02 Oct 2007 18\:00\:26 -0400")

Richard Stallman <rms@gnu.org> writes:

>     > If you want it to change only certain attributes and leave the others
>     > unchanged, you would need to call frame-attribute to get the values of
>     > the other attributes, and perhaps put them into the spec you
>     > construct, so as to make sure they won't be altered.
>
>     What does "call frame-attribute" mean? I see no such function in
>     Emacs 22.1.  Could you please give a more concrete example?
>
> Sorry, I should have written `face-attribute'.
>
>     Assuming I could understand and do what you describe, why would
>     each person need to do all of that, just to be able to change a
>     face attribute? Can't we have an Emacs function that does
>     exactly that, change certain attributes only? What was wrong
>     with `modify-face', for that matter?
>
> I don't mind.

I am looking at `face-attribute', and it looks like it would be easy
enough to rewrite `set-face-attribute' to use `face-spec-set' and
`face-attribute' instead of the current
`set-face-attribute-internal'.  Would this be a reasonable change?

-- 
Michael Welsh Duggan
(md5i@cs.cmu.edu)

  parent reply	other threads:[~2007-10-07 18:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-30 12:54 Simplification of faces Richard Stallman
2007-09-30 15:25 ` Jason Rumney
2007-10-01 17:41   ` Richard Stallman
2007-09-30 23:53 ` Drew Adams
2007-10-01 17:40   ` Richard Stallman
2007-10-01 18:18     ` Drew Adams
2007-10-02  3:32       ` Richard Stallman
2007-10-02 15:05         ` Drew Adams
2007-10-02 22:00           ` Richard Stallman
2007-10-04 16:47             ` Drew Adams
2007-10-05 16:14               ` Richard Stallman
2007-10-05 16:25                 ` Drew Adams
2007-10-07 18:29             ` Michael Welsh Duggan [this message]
2007-10-09  1:14               ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ejg63hit.fsf@maru.md5i.com \
    --to=md5i@cs.cmu.edu \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).