flymake-display-err-menu-for-current-line does not work under -nw

flymake-display-err-menu-for-current-line does not work under -nw

[Ævar Arnfjörð Bjarmason]

flymake-display-err-menu-for-current-line does not work excpet under
X. Here's one implementation for text mode that I use which displays the
errors/warnings in the echo area instead of opening a menu:

(defun flymake-display-err-message-for-current-line ()
  "Display a message with errors/warnings for current line if it
has errors and/or warnings."
  (interactive)
  (let* ((line-no             (flymake-current-line-no))
         (line-err-info-list  (nth 0 (flymake-find-err-info flymake-err-info line-no)))
         (menu-data           (flymake-make-err-menu-data line-no line-err-info-list)))
    (if menu-data
        (let ((messages))
          (push (concat (car menu-data) ":") messages)
          (dolist (error-or-warning (cadr menu-data))
            (push (car error-or-warning) messages))
          (message "%s" (mapconcat #'identity (reverse messages) "\n"))))))

I want to get this or something like it into Emacs pending comments on
whether this implementation is even a good idea. Should it use
(message)? Would it be better to use a idle timer like eldoc-mode does?
Something completely different?

Re: flymake-display-err-menu-for-current-line does not work under -nw

[Lennart Borgman (gmail)]

Ævar Arnfjörð Bjarmason wrote:
> flymake-display-err-menu-for-current-line does not work excpet under
> X. Here's one implementation for text mode that I use which displays the
> errors/warnings in the echo area instead of opening a menu:
> 
> (defun flymake-display-err-message-for-current-line ()
>   "Display a message with errors/warnings for current line if it
> has errors and/or warnings."
>   (interactive)
>   (let* ((line-no             (flymake-current-line-no))
>          (line-err-info-list  (nth 0 (flymake-find-err-info flymake-err-info line-no)))
>          (menu-data           (flymake-make-err-menu-data line-no line-err-info-list)))
>     (if menu-data
>         (let ((messages))
>           (push (concat (car menu-data) ":") messages)
>           (dolist (error-or-warning (cadr menu-data))
>             (push (car error-or-warning) messages))
>           (message "%s" (mapconcat #'identity (reverse messages) "\n"))))))
> 
> I want to get this or something like it into Emacs pending comments on
> whether this implementation is even a good idea. Should it use
> (message)? Would it be better to use a idle timer like eldoc-mode does?
> Something completely different?


Another possibility is to add the error message to the after-text or 
before-text of the overlay that flymake put on the line. However I do 
not think the text should be added to the overlay until the user 
requests it, otherwise the lines in the buffer will be jumping in an 
uncontrolled way.

Eh, but adding it to the overlay will mean that the buffer lines jumps 
afterward when flymake is removing the overlay.

Maybe it is better to check use-dialog-box?

Re: flymake-display-err-menu-for-current-line does not work under -nw

[Ævar Arnfjörð Bjarmason]

"Lennart Borgman (gmail)" <lennart.borgman@gmail.com> writes:

> Another possibility is to add the error message to the after-text or
> before-text of the overlay that flymake put on the line. However I do
> not think the text should be added to the overlay until the user
> requests it, otherwise the lines in the buffer will be jumping in an
> uncontrolled way.
>
> Eh, but adding it to the overlay will mean that the buffer lines jumps
> afterward when flymake is removing the overlay.

I'll have to check out doing this via overlays. I don't find any mention
of after-text or before-text in the Emacs sources however.

> Maybe it is better to check use-dialog-box?

I'm sorry but I don't understand, to do what? Check if we should use
flymake-display-err-menu-for-current-line?

Re: flymake-display-err-menu-for-current-line does not work under -nw

[Lennart Borgman (gmail)]

Ævar Arnfjörð Bjarmason wrote:
> "Lennart Borgman (gmail)" <lennart.borgman@gmail.com> writes:
> 
>> Another possibility is to add the error message to the after-text or
>> before-text of the overlay that flymake put on the line. However I do
>> not think the text should be added to the overlay until the user
>> requests it, otherwise the lines in the buffer will be jumping in an
>> uncontrolled way.
>>
>> Eh, but adding it to the overlay will mean that the buffer lines jumps
>> afterward when flymake is removing the overlay.
> 
> I'll have to check out doing this via overlays. I don't find any mention
> of after-text or before-text in the Emacs sources however.

Sorry, it should be 'after-string and 'before-string (but I do not think 
using them here will be very good).

   (info "(elips) Overlay Properties")

>> Maybe it is better to check use-dialog-box?
> 
> I'm sorry but I don't understand, to do what? Check if we should use
> flymake-display-err-menu-for-current-line?

I thought you said that popup menus are not supported always. I believe 
use-dialog-box should be nil if they are not (or if the user does not 
want popup messages).

Re: flymake-display-err-menu-for-current-line does not work under -nw

[Ævar Arnfjörð Bjarmason]

"Lennart Borgman (gmail)" <lennart.borgman@gmail.com> writes:

>> I'll have to check out doing this via overlays. I don't find any mention
>> of after-text or before-text in the Emacs sources however.
>
> Sorry, it should be 'after-string and 'before-string (but I do not
> think using them here will be very good).
>
>   (info "(elisp) Overlay Properties")

Thanks, I'll check out overlays.

>>> Maybe it is better to check use-dialog-box?
>>
>> I'm sorry but I don't understand, to do what? Check if we should use
>> flymake-display-err-menu-for-current-line?
>
> I thought you said that popup menus are not supported always. I
> believe use-dialog-box should be nil if they are not (or if the user
> does not want popup messages).

They're actually (x-popup-menu)'s that are not affected by the
use-dialog-box variable. It only applies to (message-or-box) and
(y-or-n-p).

I don't think (message-or-box) can be used here since the current
implementation presents a selector. Although I haven't seen it do
anything useful myself when using flymake with C and Perl.