unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* change for mac-win.el
@ 2007-12-21  9:06 David Reitter
  2007-12-22  8:08 ` YAMAMOTO Mitsuharu
  0 siblings, 1 reply; 5+ messages in thread
From: David Reitter @ 2007-12-21  9:06 UTC (permalink / raw)
  To: emacs- devel

2007-12-21  David  Reitter <david.reitter@gmail.com>

	* term/mac-win.el (mac-handle-toolbar-switch-mode): bind About event 	 
to `display-about-screen'



*** lisp/term/mac-win.el	28 Nov 2007 12:14:52 +0000	1.88.2.4
--- lisp/term/mac-win.el	21 Dec 2007 09:03:58 +0000	
***************
*** 1777,1783 ****

   (define-key mac-apple-event-map [internet-event get-url] 'mac-ae- 
get-url)

! (define-key mac-apple-event-map [hi-command about] 'display-splash- 
screen)

   ;;; Converted Carbon Events
   (defun mac-handle-toolbar-switch-mode (event)
--- 1777,1783 ----

   (define-key mac-apple-event-map [internet-event get-url] 'mac-ae- 
get-url)

! (define-key mac-apple-event-map [hi-command about] 'display-about- 
screen)

   ;;; Converted Carbon Events
   (defun mac-handle-toolbar-switch-mode (event)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: change for mac-win.el
  2007-12-21  9:06 change for mac-win.el David Reitter
@ 2007-12-22  8:08 ` YAMAMOTO Mitsuharu
  2007-12-22  9:38   ` David Reitter
  0 siblings, 1 reply; 5+ messages in thread
From: YAMAMOTO Mitsuharu @ 2007-12-22  8:08 UTC (permalink / raw)
  To: David Reitter; +Cc: emacs-devel

>>>>> On Fri, 21 Dec 2007 09:06:38 +0000, David Reitter <david.reitter@gmail.com> said:

> 2007-12-21  David  Reitter <david.reitter@gmail.com>
> 	* term/mac-win.el (mac-handle-toolbar-switch-mode): bind About event 	 
> to `display-about-screen'

`about-emacs' seems to be used in other places.  If there's no
specific reason for the preference for `display-about-screen' to
`about-emacs', I'll install the change using `about-emacs'.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: change for mac-win.el
  2007-12-22  8:08 ` YAMAMOTO Mitsuharu
@ 2007-12-22  9:38   ` David Reitter
  2007-12-23  6:16     ` YAMAMOTO Mitsuharu
  0 siblings, 1 reply; 5+ messages in thread
From: David Reitter @ 2007-12-22  9:38 UTC (permalink / raw)
  To: YAMAMOTO Mitsuharu; +Cc: emacs-devel

On 22 Dec 2007, at 08:08, YAMAMOTO Mitsuharu wrote:

>>>>>> On Fri, 21 Dec 2007 09:06:38 +0000, David Reitter <david.reitter@gmail.com 
>>>>>> > said:
>
>> 2007-12-21  David  Reitter <david.reitter@gmail.com>
>> 	* term/mac-win.el (mac-handle-toolbar-switch-mode): bind About  
>> event 	
>> to `display-about-screen'
>
> `about-emacs' seems to be used in other places.  If there's no
> specific reason for the preference for `display-about-screen' to
> `about-emacs', I'll install the change using `about-emacs'.


I don't know why the alias was introduced, but `about-emacs' seems to  
be a safe choice.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: change for mac-win.el
  2007-12-22  9:38   ` David Reitter
@ 2007-12-23  6:16     ` YAMAMOTO Mitsuharu
  2007-12-23 17:12       ` Juri Linkov
  0 siblings, 1 reply; 5+ messages in thread
From: YAMAMOTO Mitsuharu @ 2007-12-23  6:16 UTC (permalink / raw)
  To: David Reitter; +Cc: emacs-devel

>>>>> On Sat, 22 Dec 2007 09:38:29 +0000, David Reitter <david.reitter@gmail.com> said:

>>> 2007-12-21 David Reitter <david.reitter@gmail.com> *
>>> term/mac-win.el (mac-handle-toolbar-switch-mode): bind About event
>>> to `display-about-screen'
>> 
>> `about-emacs' seems to be used in other places.  If there's no
>> specific reason for the preference for `display-about-screen' to
>> `about-emacs', I'll install the change using `about-emacs'.

> I don't know why the alias was introduced, but `about-emacs' seems
> to be a safe choice.

Actually, this change has already been made in the trunk.  Maybe it is
forgotten to apply when porting the splash screen changes to the
EMACS_22_BASE branch.

2007-08-15  Juri Linkov  <juri@jurta.org>

	* term/mac-win.el (mac-apple-event-map): Bind About Emacs menu
	item to about-emacs instead of display-splash-screen.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: change for mac-win.el
  2007-12-23  6:16     ` YAMAMOTO Mitsuharu
@ 2007-12-23 17:12       ` Juri Linkov
  0 siblings, 0 replies; 5+ messages in thread
From: Juri Linkov @ 2007-12-23 17:12 UTC (permalink / raw)
  To: YAMAMOTO Mitsuharu; +Cc: David Reitter, emacs-devel

>> I don't know why the alias was introduced, but `about-emacs' seems
>> to be a safe choice.
>
> Actually, this change has already been made in the trunk.  Maybe it is
> forgotten to apply when porting the splash screen changes to the
> EMACS_22_BASE branch.
>
> 2007-08-15  Juri Linkov  <juri@jurta.org>
>
> 	* term/mac-win.el (mac-apple-event-map): Bind About Emacs menu
> 	item to about-emacs instead of display-splash-screen.

I guess it is.  Thanks for the catch.

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-12-23 17:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-21  9:06 change for mac-win.el David Reitter
2007-12-22  8:08 ` YAMAMOTO Mitsuharu
2007-12-22  9:38   ` David Reitter
2007-12-23  6:16     ` YAMAMOTO Mitsuharu
2007-12-23 17:12       ` Juri Linkov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).