From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Fri, 07 Mar 2008 09:24:17 +0100 Message-ID: <87ejan7xhq.fsf@member.fsf.org> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204878289 2546 80.91.229.12 (7 Mar 2008 08:24:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Mar 2008 08:24:49 +0000 (UTC) Cc: Karl Fogel , Stefan Monnier , Reiner Steib , emacs-devel@gnu.org To: Bastien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 07 09:25:15 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXXt5-0005xE-51 for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 09:25:07 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXXsX-0007JH-Aa for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 03:24:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXXsT-0007J4-El for emacs-devel@gnu.org; Fri, 07 Mar 2008 03:24:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXXsO-0007IF-1M for emacs-devel@gnu.org; Fri, 07 Mar 2008 03:24:28 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXXsN-0007IC-TM for emacs-devel@gnu.org; Fri, 07 Mar 2008 03:24:23 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JXXsN-0005Gi-Kg for emacs-devel@gnu.org; Fri, 07 Mar 2008 03:24:23 -0500 Original-Received: from out3.smtp.messagingengine.com ([66.111.4.27]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JXXsM-0000V0-Tg for emacs-devel@gnu.org; Fri, 07 Mar 2008 03:24:23 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 87D5EB4FFF; Fri, 7 Mar 2008 03:24:21 -0500 (EST) Original-Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 07 Mar 2008 03:24:21 -0500 X-Sasl-enc: AmNEVYbCucAUccHzsn7f52+qIz6Gug0Ids83aGuoJ0H9 1204878260 Original-Received: from localhost (dslb-084-063-012-045.pools.arcor-ip.net [84.63.12.45]) by mail.messagingengine.com (Postfix) with ESMTPA id A5C74BB94; Fri, 7 Mar 2008 03:24:19 -0500 (EST) Mail-Followup-To: Bastien , Stefan Monnier , Karl Fogel , Reiner Steib , emacs-devel@gnu.org In-Reply-To: <87iqzzigv6.fsf@bzg.ath.cx> (Bastien's message of "Thu, 06 Mar 2008 23:15:41 +0000") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91613 Archived-At: Bastien writes: Hi Bastien, >>> He added the buffer-local variable `bookmark-make-cell-function', >>> which lets you define a handler for a mode: when setting a bookmark, >>> a handler is added to the record and jumping to the bookmark will >>> use this handler instead of `bookmark-jump' (see >>> `bookmark-jump-internal'.) >> >>> This is all good, but it only works for buffer visiting files and >>> Info-mode. >> >> I don't understand why you think so. Could you explain in more >> details? > > This boils down to this: having a `bookmark-make-name-function' doing > for the names of the bookmarks what `bookmark-make-cell-function' does > for the records. This would be locally set depending on the mode > we're in. > > For now the the name of the bookmark is set by > bookmark-buffer-file-name which doesn't return anything unless you are > in a buffer visiting a file or an Info node, or dired. Hm, looking at the code `bookmark-buffer-file-name' is only called for buffers that don't have `bookmark-make-record-function' set locally, so I don't see why you would need that? Or am I late again and Karl's and Stefan's changes already do care oy everything we need? Bye, Tassilo