From: Jason Rumney <jasonr@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Chong Yidong <cyd@stupidchicken.com>,
5703@debbugs.gnu.org, emacs-devel@gnu.org
Subject: Re: bug#5703: 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top'
Date: Tue, 30 Mar 2010 22:41:11 +0800 [thread overview]
Message-ID: <87eij1swhk.fsf@home.jasonrumney.net> (raw)
In-Reply-To: <83pr2mympy.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Mar 2010 16:15:37 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> I think the small patch below fixes this. But since this is about
> pretest, I would like second opinion on that from anyone who is
> familiar with this stuff (not only on MS-Windows). In particular, I'd
> like to hear from Jason.
If I understand your patch correctly, what you are effectively doing is
to compute the x and y location of the tooltip, then patch it up
afterwards if explicit arguments were given. This seems ok for a
temporary workaround until the reason Windows behaviour differs from
other plaforms can be found.
> === modified file 'src/w32fns.c'
> --- src/w32fns.c 2010-01-13 08:35:10 +0000
> +++ src/w32fns.c 2010-03-30 12:57:13 +0000
> @@ -5927,6 +5927,10 @@ Text larger than the specified size is c
> /* Move the tooltip window where the mouse pointer is. Resize and
> show it. */
> compute_tip_xy (f, parms, dx, dy, width, height, &root_x, &root_y);
> + if (f->top_pos)
> + root_y = f->top_pos;
> + if (f->left_pos)
> + root_x = f->left_pos;
>
> {
> /* Adjust Window size to take border into account. */
next prev parent reply other threads:[~2010-03-30 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DF5796ECD96A4DD2807094BE7934B041@us.oracle.com>
2010-03-13 20:15 ` 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top' Chong Yidong
2010-03-13 22:03 ` Christoph
2010-03-14 4:49 ` Drew Adams
2010-03-30 13:18 ` Eli Zaretskii
2010-03-30 13:15 ` bug#5703: " Eli Zaretskii
2010-03-30 14:41 ` Jason Rumney [this message]
2010-03-30 16:23 ` Eli Zaretskii
2010-03-30 23:33 ` YAMAMOTO Mitsuharu
2010-03-31 9:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eij1swhk.fsf@home.jasonrumney.net \
--to=jasonr@gnu.org \
--cc=5703@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).