From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Wed, 02 Feb 2011 10:24:59 +0100 Message-ID: <87ei7qrdp0.fsf@gmail.com> References: <87ipxaidea.fsf@gmail.com> <87k4hp96g0.fsf@stupidchicken.com> <878vy59ejz.fsf@stupidchicken.com> <87lj23ickn.fsf@stupidchicken.com> <87sjway8i3.fsf@gmx.de> <87wrll2ebe.fsf@stupidchicken.com> <87hbcot7gq.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1296668042 354 80.91.229.12 (2 Feb 2011 17:34:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 2 Feb 2011 17:34:02 +0000 (UTC) Cc: Chong Yidong , Stefan Monnier , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 02 18:33:57 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pkgaa-0003bA-IA for ged-emacs-devel@m.gmane.org; Wed, 02 Feb 2011 18:33:56 +0100 Original-Received: from localhost ([127.0.0.1]:35372 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkgaZ-00057A-UD for ged-emacs-devel@m.gmane.org; Wed, 02 Feb 2011 12:33:56 -0500 Original-Received: from [140.186.70.92] (port=52298 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pkdvz-0002jV-V2 for emacs-devel@gnu.org; Wed, 02 Feb 2011 09:44:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkYxT-0003R7-Qb for emacs-devel@gnu.org; Wed, 02 Feb 2011 04:25:05 -0500 Original-Received: from mail-ww0-f41.google.com ([74.125.82.41]:36843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkYxT-0003OT-K1 for emacs-devel@gnu.org; Wed, 02 Feb 2011 04:25:03 -0500 Original-Received: by wwi18 with SMTP id 18so5736524wwi.0 for ; Wed, 02 Feb 2011 01:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=SCJtJM50W0nkOoJSoZtCLSp5uNf/4CzAj8uN//AXvGI=; b=qpjjPS6rBX0CMLRR5aTjzsFNsI7GopJoc1FqBZdDUnMzorAU2JR5swaSRm6yds9KTI yD2xBloLJpmMx0IHFy7NFy07NoU9Lw6Dbon3bguPdE7oLNvvKQvJM9sG2SIdq4SwmSdb RdnBU3KEJxr1OZUazy+Axyt+CcBSqxz6rPFtY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=kvwInrs7XZ9FyS0+dRwrR2oPoOpPg+qbH1RECh1hu595g0YN49RRAUtWibczkGxW9l 3Dh7cMnLNaj+5Cd/XSxbhsqfe8iEQ5ksVClSEEWniAZZv0CjrQL8NGrzL9v3kfa8Skr+ Ugzdtpg4oSQY9dVcdWrtQqTjg+m/mdRD1vWPY= Original-Received: by 10.227.127.141 with SMTP id g13mr8952420wbs.62.1296638702216; Wed, 02 Feb 2011 01:25:02 -0800 (PST) Original-Received: from thierry-MM061 (63.211.85-79.rev.gaoland.net [79.85.211.63]) by mx.google.com with ESMTPS id f35sm16812358wbf.14.2011.02.02.01.25.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 02 Feb 2011 01:25:01 -0800 (PST) In-Reply-To: <87hbcot7gq.fsf@gmx.de> (Michael Albinus's message of "Tue, 01 Feb 2011 10:44:21 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135471 Archived-At: Michael Albinus writes: > Chong Yidong writes: > >> Michael Albinus writes: > It works fine, thank you. But there seems to be a bug in dired; when I > copy "/tmp/test" to "~/" twice, I see the corrupted directory structure. What we could do also is create a function copy-directory-contents, that reuse the code of precedent version of copy-directory (but not interactive this time) and call this function in dired-copy-file-recursive instead of copy-directory. In this case we could rewrite copy-directory to avoid duplicate code, possibly: (no urge in this case as actual copy-directory works fine) 1) Writing copy-directory-contents (or whatever name) to allow creating the structure like actual copy-directory, or not like ancient version leaving this job to dired-create-files. 2) Writing a copy-directory that reuse dired code (i.e dired-create-files). In this case it would have all interactive messages, ask etc.. WDYT? -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997