From: "Stephen J. Turnbull" <stephen@xemacs.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: "Óscar Fuentes" <ofv@wanadoo.es>, emacs-devel@gnu.org
Subject: Re: Please don't use revision numbers on commit messages (and elsewhere).
Date: Fri, 01 Apr 2011 10:59:08 +0900 [thread overview]
Message-ID: <87ei5mvij7.fsf@uwakimon.sk.tsukuba.ac.jp> (raw)
In-Reply-To: <AANLkTimiuSOdOvkki9EGb7Nq43znjy8VHAZKJLE0ousH@mail.gmail.com>
Juanma Barranquero writes:
> On Fri, Apr 1, 2011 at 02:11, Óscar Fuentes <ofv@wanadoo.es> wrote:
>
> > The Emacs project has a number of branches published on a well-known
> > site, and hopefully other branches distributed along a number of
> > personal machines. I'm saying that using revision numbers is confusing
> > when those revisions are merged across branches.
>
> Yes, and I'm saying that, so far, it seems quite clear from the
> context which branch a revno refers to.
That's only because so far, people don't lose push races often enough
for it to matter. Commits that from your point of view are on the
mainline really are on local branches until you succeed in pushing.
If you use a bound branch, you're saved from that, true (this is not
entirely trivial, but I'm pretty sure in practice it will be true).
But bound branches suck for anything much bigger than a typo fix.
If you lose a push race, you have to undo the commit so you can redo
the commit message. That (a) sucks even if you know what you're
doing, and (b) is probably beyond the average Emacs committer at that
moment. (b) is no insult, just my estimate of a fact, and I see *no
reason* why that should change. And of course (c) a lot of people
will forget (or never know about it in the first place). I've been
annoyed by this a couple of times in XEmacs.
> I don't foresee that super-distributed future that you imagine for
> Emacs.
It doesn't require a super-distributed future, just an Emacs sprint.
Then you'll see people losing push races all over the place, and
anybody who's using revnos will have to go back and fix them.
> And if it does come to pass, it's everyone's responsibility to
> clearly label their revnos.
Well, OK, but I don't see how you can "label" a revno that's (a) just
plain wrong and (b) embedded in a commit message that can't be changed.
The right thing to do is to use a revid (which is bzr-friendly), or
ttn's literary style of commit message (which is people-friendly,
except to the committer and people who really exercise the capability
of the VCS).
> No. Use always revision numbers and trust the users to be smart.
"Smart" is one thing, "anal retentive" is another. Especially at any
time it's likely to matter (ie, the commit rushes that always occur
just before a freeze). People are going to be frustrated enough by
losing push races. They're not going to want to rebase their local
commits (and this has to be done by hand since the commit messages
need to be changed) at that point in time.
next prev parent reply other threads:[~2011-04-01 1:59 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 20:47 Please don't use revision numbers on commit messages (and elsewhere) Óscar Fuentes
2011-03-31 21:36 ` Lennart Borgman
2011-03-31 21:53 ` Óscar Fuentes
2011-03-31 21:59 ` Lennart Borgman
2011-03-31 22:06 ` Óscar Fuentes
2011-03-31 22:18 ` Lennart Borgman
2011-03-31 22:58 ` Juanma Barranquero
2011-04-01 7:42 ` Eli Zaretskii
2011-04-01 7:58 ` Andreas Schwab
2011-04-01 8:02 ` Eli Zaretskii
2011-04-01 8:17 ` Andreas Schwab
2011-04-01 8:42 ` Eli Zaretskii
2011-04-01 8:54 ` Andreas Schwab
2011-04-01 10:11 ` Eli Zaretskii
2011-04-01 10:21 ` Andreas Schwab
2011-04-01 10:48 ` Eli Zaretskii
2011-04-01 11:18 ` Andreas Schwab
2011-04-01 13:15 ` Eli Zaretskii
2011-04-01 13:32 ` Andreas Schwab
2011-04-01 13:47 ` Eli Zaretskii
2011-04-01 13:51 ` Deniz Dogan
2011-04-01 15:26 ` Óscar Fuentes
2011-04-01 19:13 ` Eli Zaretskii
2011-04-01 20:17 ` Óscar Fuentes
2011-03-31 23:14 ` Juanma Barranquero
2011-04-01 0:11 ` Óscar Fuentes
2011-04-01 0:28 ` Juanma Barranquero
2011-04-01 1:20 ` Óscar Fuentes
2011-04-01 8:18 ` Eli Zaretskii
2011-04-01 12:08 ` David Kastrup
2011-04-01 13:15 ` Eli Zaretskii
2011-04-01 15:35 ` Óscar Fuentes
2011-04-01 19:52 ` Eli Zaretskii
2011-04-01 20:04 ` David Kastrup
2011-04-01 20:36 ` Eli Zaretskii
2011-04-01 20:43 ` Óscar Fuentes
2011-04-01 10:34 ` Juanma Barranquero
2011-04-01 15:55 ` Óscar Fuentes
2011-04-01 21:53 ` Juanma Barranquero
2011-04-04 16:32 ` Nils Ackermann
2011-04-04 21:27 ` Juanma Barranquero
2011-04-04 21:36 ` Lennart Borgman
2011-04-04 21:49 ` Juanma Barranquero
2011-04-04 22:03 ` Lennart Borgman
2011-04-04 22:09 ` Juanma Barranquero
2011-04-04 22:27 ` Stefan Monnier
2011-04-04 22:35 ` Juanma Barranquero
2011-04-05 21:00 ` Thien-Thi Nguyen
2011-04-05 21:00 ` Thien-Thi Nguyen
2011-04-06 1:30 ` Stefan Monnier
2011-04-06 2:55 ` Stephen J. Turnbull
2011-04-06 12:47 ` Thien-Thi Nguyen
2011-04-01 1:59 ` Stephen J. Turnbull [this message]
2011-04-01 10:00 ` Uday S Reddy
2011-04-01 15:00 ` Stephen J. Turnbull
2011-04-01 16:38 ` Uday S Reddy
2011-04-01 18:08 ` Stephen J. Turnbull
2011-04-01 18:56 ` Uday S Reddy
2011-04-01 20:49 ` Stephen J. Turnbull
2011-04-01 10:45 ` Juanma Barranquero
2011-04-01 14:51 ` Stefan Monnier
2011-04-01 15:14 ` Ted Zlatanov
2011-04-01 19:58 ` Juanma Barranquero
2011-04-02 2:12 ` Chong Yidong
2011-04-01 1:35 ` Stephen J. Turnbull
2011-04-01 10:39 ` Juanma Barranquero
2011-03-31 23:16 ` Thien-Thi Nguyen
2011-04-01 0:20 ` Óscar Fuentes
2011-04-01 8:38 ` Thien-Thi Nguyen
2011-04-01 9:36 ` Eli Zaretskii
2011-04-01 10:14 ` Eli Zaretskii
2011-04-01 17:38 ` Thien-Thi Nguyen
2011-04-01 15:38 ` Óscar Fuentes
2011-04-01 19:12 ` Eli Zaretskii
2011-04-01 20:21 ` Óscar Fuentes
2011-04-01 20:38 ` Eli Zaretskii
2011-04-01 21:40 ` Uday S Reddy
2011-04-02 0:03 ` Óscar Fuentes
2011-04-02 6:20 ` Uday S Reddy
2011-04-02 13:47 ` Óscar Fuentes
2011-04-03 8:00 ` Uday S Reddy
2011-04-03 16:13 ` Óscar Fuentes
2011-04-04 9:29 ` Uday S Reddy
2011-04-05 2:20 ` Stephen J. Turnbull
2011-04-02 2:57 ` Stephen J. Turnbull
2011-04-01 0:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei5mvij7.fsf@uwakimon.sk.tsukuba.ac.jp \
--to=stephen@xemacs.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).