* [Patch] lisp/help.el (where-is): Don't overwrite `standard-output'
@ 2011-09-12 21:19 Michael Markert
2011-09-12 23:01 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Michael Markert @ 2011-09-12 21:19 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 299 bytes --]
Hi,
I tried to use `where-is' programmatically to avoid doing the parsing
myself but failed because `where-is' resets `standard-output' to `t'.
The appended patch keeps `standard-output' unless told otherwise and
thus enabled getting the output via `with-output-to-string' and the
like.
Michael
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: where-is-honor-standard-output.patch --]
[-- Type: text/x-patch, Size: 518 bytes --]
diff -Naur a/help.el b/help.el
--- a/help.el 2011-09-12 23:04:47.336591539 +0200
+++ b/help.el 2011-09-12 23:05:51.748593189 +0200
@@ -527,7 +527,7 @@
(unless definition (error "No command"))
(let ((func (indirect-function definition))
(defs nil)
- (standard-output (if insert (current-buffer) t)))
+ (standard-output (if insert (current-buffer) standard-output)))
;; In DEFS, find all symbols that are aliases for DEFINITION.
(mapatoms (lambda (symbol)
(and (fboundp symbol)
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] lisp/help.el (where-is): Don't overwrite `standard-output'
2011-09-12 21:19 [Patch] lisp/help.el (where-is): Don't overwrite `standard-output' Michael Markert
@ 2011-09-12 23:01 ` Glenn Morris
2011-09-13 9:36 ` Michael Markert
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2011-09-12 23:01 UTC (permalink / raw)
To: Michael Markert; +Cc: emacs-devel
This is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9030
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] lisp/help.el (where-is): Don't overwrite `standard-output'
2011-09-12 23:01 ` Glenn Morris
@ 2011-09-13 9:36 ` Michael Markert
0 siblings, 0 replies; 3+ messages in thread
From: Michael Markert @ 2011-09-13 9:36 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
On 13 Sep 2011, Glenn Morris wrote:
>
> This is http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9030
Hmm should have checked the bugs beforehand, sorry.
Thanks for applying!
Michael
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-13 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-12 21:19 [Patch] lisp/help.el (where-is): Don't overwrite `standard-output' Michael Markert
2011-09-12 23:01 ` Glenn Morris
2011-09-13 9:36 ` Michael Markert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).