From: Dmitry Gutov <dgutov@yandex.ru>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where appropriate.
Date: Fri, 01 Nov 2013 07:43:06 +0400 [thread overview]
Message-ID: <87eh70bxdh.fsf@yandex.ru> (raw)
In-Reply-To: <CAM9Zgm0B=N2L3SfjOX-xjqEkN=T6PV1xh6VFPTLN2O-5YSxv9Q@mail.gmail.com> (Bozhidar Batsov's message of "Thu, 31 Oct 2013 21:44:50 +0200")
Bozhidar Batsov <bozhidar@batsov.com> writes:
> I think that we don't need to worry about compatibility with the other version of the ruby-mode in
> Ruby's SVN repo, since just about nobody uses it (except maybe some Emacs 23 users?).
I think more importantly, no one's trying to merge the code from the
trunk ruby-mode back to the Ruby repo (at least, in its entirety), or
use this package separately from the Emacs trunk.
> ruby-mode suffers from a lot of legacy in it (compared to other built-in modes) and would
> definitely benefit from a clean up. After all, simpler code is always easier to improve, extend
> and debug.
+1
I can't say it's too hard to understand, but the code will be easier to
understand for a new reader without the (fboundp
'syntax-propertize-rules) mess at the end.
next prev parent reply other threads:[~2013-11-01 3:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 12:40 [PATCH] * lisp/progmodes/ruby-mode.el: Use `setq-local' where appropriate Bozhidar Batsov
2013-10-31 17:55 ` Stefan Monnier
2013-10-31 19:44 ` Bozhidar Batsov
2013-11-01 3:43 ` Dmitry Gutov [this message]
2013-11-01 12:26 ` Stefan Monnier
2013-11-02 0:23 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh70bxdh.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=bozhidar@batsov.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).