unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* GtkHandleBox in GTK3 looks awful and is deprecated: can we stop using it?
@ 2014-01-13  2:18 Daniel Colascione
  2014-01-13 10:58 ` Stephen Berman
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Colascione @ 2014-01-13  2:18 UTC (permalink / raw)
  To: emacs developers

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

In GTK3 builds, at least with the default Unity GKT+ theme, GtkHandleBox 
looks awful because it's not styled with other widgets. The feature it's 
supposed to provide doesn't even work: detaching the toolbar just yields 
a zero-size window. GtkHandleBox is deprecated in GTK+3 and it will be 
removed eventually; there is no replacement. Can we just compile without 
HAVE_GTK_HANDLE_BOX_NEW? Does this feature get much use?

[-- Attachment #2: emacs.png --]
[-- Type: image/png, Size: 27236 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: GtkHandleBox in GTK3 looks awful and is deprecated: can we stop using it?
  2014-01-13  2:18 GtkHandleBox in GTK3 looks awful and is deprecated: can we stop using it? Daniel Colascione
@ 2014-01-13 10:58 ` Stephen Berman
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Berman @ 2014-01-13 10:58 UTC (permalink / raw)
  To: Daniel Colascione; +Cc: emacs developers

On Sun, 12 Jan 2014 18:18:16 -0800 Daniel Colascione <dancol@dancol.org> wrote:

> In GTK3 builds, at least with the default Unity GKT+ theme, GtkHandleBox looks
> awful because it's not styled with other widgets.

I agree it doesn't look good.

>                                                   The feature it's supposed to
> provide doesn't even work: detaching the toolbar just yields a zero-size
> window.

If you set x-gtk-whole-detached-tool-bar to t then the whole toolbar is
displayed when detached.  However, with the default value nil, there is
indeed no button displayed, just the handle and an empty strip one
character wide.  It used to show a clickable arrow that would expand the
toolbar.  I don't know if this regression was introduced in gtk3.

>         GtkHandleBox is deprecated in GTK+3 and it will be removed eventually;
> there is no replacement. Can we just compile without HAVE_GTK_HANDLE_BOX_NEW?
> Does this feature get much use?

I've occasionally used it, but not in a long time (hence didn't notice
the above regression).  Now having tried it again, I observe another
bug: detaching and reattaching the toolbar causes the frame to shrink
(vertically, if the toolbar is displayed on the top or bottom of the
fram; horizontally, if it's displayed on the left or right.)  I don't
know if this bug is also new with gtk3; it seems to be different from
previous frame-shrinking bugs I've reported (bug#3243, bug#14627).  But
if detaching the toolbar is on the way out, it may not be worth making a
new bug report.

Steve Berman



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-13 10:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-13  2:18 GtkHandleBox in GTK3 looks awful and is deprecated: can we stop using it? Daniel Colascione
2014-01-13 10:58 ` Stephen Berman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).