From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH][BUG]: eww doesnt trim whitespace from address Date: Mon, 03 Nov 2014 08:46:45 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87egtkbdmi.fsf@lifelogs.com> References: Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1415022649 3938 80.91.229.3 (3 Nov 2014 13:50:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Nov 2014 13:50:49 +0000 (UTC) Cc: Vibhav Pant To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 03 14:50:42 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XlI1n-0003I3-Nr for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2014 14:50:39 +0100 Original-Received: from localhost ([::1]:34892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlI1n-0001q5-5D for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2014 08:50:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlI1N-0001mN-8k for emacs-devel@gnu.org; Mon, 03 Nov 2014 08:50:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlI1F-0007AA-Oo for emacs-devel@gnu.org; Mon, 03 Nov 2014 08:50:13 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:33225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlI1F-00078S-JB for emacs-devel@gnu.org; Mon, 03 Nov 2014 08:50:05 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XlI1C-0002wV-U4 for emacs-devel@gnu.org; Mon, 03 Nov 2014 14:50:02 +0100 Original-Received: from c-98-229-61-72.hsd1.ma.comcast.net ([98.229.61.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 03 Nov 2014 14:50:02 +0100 Original-Received: from tzz by c-98-229-61-72.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 03 Nov 2014 14:50:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 19 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-61-72.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:Kd+I4yAetBTVJb7rGYiVCX7e12U= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176272 Archived-At: On Fri, 21 Mar 2014 14:57:37 +0530 Vibhav Pant wrote: VP> As of now, eww does not rim the user specified address, this often VP> leads to problems especially if the address is from the clipboard (eww VP> reports that the service isnt known). Most browsers automatically do VP> this, so I have included a patch to solve this problem. VP> This patch simply setq's url to a "trimmed" version of it. VP> The change is pretty non trivial, so I think it can be included in this release. I think the fairly recent function `string-trim' would be better than the proposed regex approach. I also don't know if there are any exceptions to this--are there cases where you want to preserve the trailing space on a URL and/or encode them to "%20"? Thanks Ted