From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 c2ba4a2: ; Added documentation for undo-auto functionality. Date: Thu, 03 Dec 2015 21:47:32 +0000 Message-ID: <87egf3xkzv.fsf@russet.org.uk> References: <83oaeaj5la.fsf@gnu.org> <87si3jo2pt.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1449179278 8142 80.91.229.3 (3 Dec 2015 21:47:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Dec 2015 21:47:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 03 22:47:49 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a4bj9-0008RL-0u for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2015 22:47:47 +0100 Original-Received: from localhost ([::1]:37547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4bj8-0004jb-EP for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2015 16:47:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4bj4-0004jL-8p for emacs-devel@gnu.org; Thu, 03 Dec 2015 16:47:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4bj1-0005mr-1D for emacs-devel@gnu.org; Thu, 03 Dec 2015 16:47:42 -0500 Original-Received: from cheviot12.ncl.ac.uk ([128.240.234.12]:33190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4bj0-0005jd-R6 for emacs-devel@gnu.org; Thu, 03 Dec 2015 16:47:38 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot12.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1a4biz-0003kl-9j; Thu, 03 Dec 2015 21:47:37 +0000 Original-Received: from cpc6-benw10-2-0-cust45.gate.cable.virginm.net ([92.238.179.46] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a4biy-00033d-66; Thu, 03 Dec 2015 21:47:36 +0000 In-Reply-To: (Stefan Monnier's message of "Thu, 3 Dec 2015 14:51:01 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195833 Archived-At: Stefan Monnier writes: >> Deciding what is "end-user" functionality and what is "implementation" >> gets a bit hard when you are talking about code of this form. > > When in doubt, I recommend to err on the side of not documenting. I think in this case, the function and variable should probably not be internal. The undo-auto-amalgamate function in particular, might well be of use outside. Phil