From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: builds are getting slower? Date: Tue, 15 Dec 2015 13:49:07 +0100 Message-ID: <87egen7u7w.fsf@fencepost.gnu.org> References: <8337vab7nx.fsf@gnu.org> <0d7fkmdxj1.fsf@fencepost.gnu.org> <566D0BEB.4010707@cs.ucla.edu> <52wpsif21j.fsf@fencepost.gnu.org> <6tpoy9aorv.fsf@fencepost.gnu.org> <83fuz54sfk.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1450183775 11914 80.91.229.3 (15 Dec 2015 12:49:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Dec 2015 12:49:35 +0000 (UTC) Cc: Glenn Morris , Eli Zaretskii , Paul Eggert , emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 15 13:49:33 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8p2q-0006Eo-P7 for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 13:49:32 +0100 Original-Received: from localhost ([::1]:36599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8p2q-0002cV-9F for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 07:49:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8p2c-0002c9-2x for emacs-devel@gnu.org; Tue, 15 Dec 2015 07:49:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8p2b-0005rD-AY for emacs-devel@gnu.org; Tue, 15 Dec 2015 07:49:18 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8p2S-0005q9-R7; Tue, 15 Dec 2015 07:49:08 -0500 Original-Received: from localhost ([127.0.0.1]:38844 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.82) (envelope-from ) id 1a8p2R-00083h-Oi; Tue, 15 Dec 2015 07:49:08 -0500 Original-Received: by lola (Postfix, from userid 1000) id 4BDDFDFFC5; Tue, 15 Dec 2015 13:49:07 +0100 (CET) In-Reply-To: (Artur Malabarba's message of "Tue, 15 Dec 2015 12:38:07 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196298 Archived-At: Artur Malabarba writes: > 2015-12-15 8:18 GMT+00:00 Glenn Morris : >> >> On investigation, I find 2e84888 caused a 20% increase in build time. >> > > Looks like that's my commit. I'm attaching the diff of this commit > below so that people can have a look and help pinpoint something. > I only see 2 things that could be to blame: This is a very, very large commit. It should have been split into multiple commits addressing separate issues. However, in the description one thing stands out: > * lisp/files.el (dir-locals-file): Allow wildcards Depending on how the wildcard search is organized, this may make the decisive difference. Can people split the timing tests into user and system time? Because if the directory search is at fault, it may be the system time that hits here. -- David Kastrup