From: Mitchel Humpherys <mitch.special@gmail.com>
To: emacs-devel@gnu.org
Cc: Kristoffer Gronlund <krig@koru.se>
Subject: Re: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region
Date: Sat, 27 Feb 2016 22:05:05 -0800 [thread overview]
Message-ID: <87egbxid4e.fsf@gmail.com> (raw)
In-Reply-To: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> (Mitchel Humpherys's message of "Mon, 22 Feb 2016 17:04:31 -0800")
On Mon, Feb 22 2016 at 05:04:31 PM, Mitchel Humpherys <mitch.special@gmail.com> wrote:
> Setting a foreground color on the `region' face is slightly annoying.
> This is subjective, of course, but the consensus among other themes and
> around the web is to *not* set a foreground color on the region face.
Any objections to this? I should have mentioned that the reason it's
slightly annoying is because setting a foreground color hides existing
syntax highlighting within the region text.
--
Mitch
next prev parent reply other threads:[~2016-02-28 6:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 1:04 [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Mitchel Humpherys
2016-02-28 6:05 ` Mitchel Humpherys [this message]
2016-02-28 6:21 ` Lars Ingebrigtsen
2016-02-28 8:13 ` Kristoffer Grönlund
2016-02-28 15:53 ` Drew Adams
2016-03-14 17:22 ` Mitchel Humpherys
2016-03-14 17:31 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egbxid4e.fsf@gmail.com \
--to=mitch.special@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=krig@koru.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).