From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Leach Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v5] Add systemd socket launching support Date: Wed, 27 Apr 2016 10:56:29 +0100 Message-ID: <87eg9r5q9e.fsf@mattleach.net> References: <871t6do8w1.fsf@mattleach.net> <87inzkrs8c.fsf@mattleach.net> <5713224F.9040602@cs.ucla.edu> <87h9f0ealq.fsf@mattleach.net> <57147449.4060307@cs.ucla.edu> <874maun0el.fsf@mattleach.net> <87zisg91an.fsf@mattleach.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461751392 19265 80.91.229.3 (27 Apr 2016 10:03:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Apr 2016 10:03:12 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 27 12:03:05 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avMJF-0001JZ-I3 for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 12:03:05 +0200 Original-Received: from localhost ([::1]:42189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avMJF-00084P-2M for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 06:03:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avMD6-0003O1-PS for emacs-devel@gnu.org; Wed, 27 Apr 2016 05:56:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avMD3-0001Uv-Hb for emacs-devel@gnu.org; Wed, 27 Apr 2016 05:56:44 -0400 Original-Received: from mx0.mattleach.net ([176.58.118.143]:52680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avMD3-0001Ts-Bq for emacs-devel@gnu.org; Wed, 27 Apr 2016 05:56:41 -0400 Original-Received: by mx0.mattleach.net (Postfix, from userid 99) id 7DF226222F; Wed, 27 Apr 2016 10:56:36 +0100 (BST) Original-Received: from buxton.mattleach.net (cpc5-walt15-0-0-cust40.13-2.cable.virginm.net [82.17.24.41]) by mx0.mattleach.net (Postfix) with ESMTPSA id B653862227; Wed, 27 Apr 2016 10:56:35 +0100 (BST) In-Reply-To: (Paul Eggert's message of "Tue, 26 Apr 2016 09:15:10 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 176.58.118.143 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203384 Archived-At: Paul Eggert writes: > On 04/26/2016 02:17 AM, Matthew Leach wrote: >> Should I send in a patch to fix this or are you OK doing it? > > I should do it since I introduced the bug :-(. Thanks for reporting > it. I installed the attached; does it work for you? Yes, that has fixed it. Thanks for that :-). > (Can you write a test case for this sort of bug, something 'make > check' could check?) The only way that I can think of dong it is to set the environment variables that systemd would, launch Emacs in some kind of special test mode and check if it uses the socket. I'm open to suggestions, though. Thanks, -- Matt