unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Matthew Leach <matthew@mattleach.net>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH v5] Add systemd socket launching support
Date: Wed, 27 Apr 2016 10:56:29 +0100	[thread overview]
Message-ID: <87eg9r5q9e.fsf@mattleach.net> (raw)
In-Reply-To: <a6e42ae8-0300-351d-1c6f-1b9d9694a34d@cs.ucla.edu> (Paul Eggert's message of "Tue, 26 Apr 2016 09:15:10 -0700")

Paul Eggert <eggert@cs.ucla.edu> writes:

> On 04/26/2016 02:17 AM, Matthew Leach wrote:
>> Should I send in a patch to fix this or are you OK doing it?
>
> I should do it since I introduced the bug :-(. Thanks for reporting
> it. I installed the attached; does it work for you?

Yes, that has fixed it.  Thanks for that :-).

> (Can you write a test case for this sort of bug, something 'make
> check' could check?)

The only way that I can think of dong it is to set the environment
variables that systemd would, launch Emacs in some kind of special test
mode and check if it uses the socket.  I'm open to suggestions, though.

Thanks,
-- 
Matt



  reply	other threads:[~2016-04-27  9:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-10 14:06 [PATCH v5] Add systemd socket launching support Matthew Leach
2016-04-14 17:54 ` Matthew Leach
2016-04-17  5:42   ` Paul Eggert
2016-04-17 11:30     ` Matthew Leach
2016-04-18  5:44       ` Paul Eggert
2016-04-18 19:33         ` Matthew Leach
2016-04-21 20:59         ` Matthew Leach
2016-04-26  9:17           ` Matthew Leach
2016-04-26 16:15             ` Paul Eggert
2016-04-27  9:56               ` Matthew Leach [this message]
2016-04-16  9:50 ` Eli Zaretskii
2016-04-17 11:15   ` Matthew Leach
2016-04-21 16:17     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eg9r5q9e.fsf@mattleach.net \
    --to=matthew@mattleach.net \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).