From: Michael Heerdegen <michael_heerdegen@web.de>
To: emacs-devel@gnu.org
Cc: Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode
Date: Sat, 30 Apr 2016 16:05:33 +0200 [thread overview]
Message-ID: <87eg9ndweq.fsf@web.de> (raw)
In-Reply-To: jwvzisb6wzb.fsf-monnier+emacsdiffs@gnu.org
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> > (kill-local-variable 'eldoc-message-commands)
> > (remove-hook 'post-command-hook 'eldoc-schedule-timer t)
> > - (remove-hook 'pre-command-hook
> > 'eldoc-pre-command-refresh-echo-area t))))
> > + (remove-hook 'pre-command-hook
> > 'eldoc-pre-command-refresh-echo-area t)
> > + (when eldoc-timer
> > + (cancel-timer eldoc-timer)
> > + (setq eldoc-timer nil)))))
>
> Hmm... IIUC the timer is global (i.e. shared by all buffers), whereas
> the above code is run when disabling eldoc-mode in one particular
> buffer. So it doesn't look right.
Yes.
And Lars, please also see bug#19853. When Dmitry will fix this, I think
this issue here will be fixed as side effect.
Michael.
prev parent reply other threads:[~2016-04-30 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160429200756.7743.70425@vcs.savannah.gnu.org>
[not found] ` <E1awEhg-00021a-KD@vcs.savannah.gnu.org>
2016-04-30 13:36 ` [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode Stefan Monnier
2016-04-30 13:58 ` Lars Ingebrigtsen
2016-04-30 14:30 ` Stefan Monnier
2016-04-30 14:05 ` Michael Heerdegen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg9ndweq.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).