From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 3a21ea1: Add more abbrev tests Date: Tue, 03 May 2016 19:22:01 +0200 Message-ID: <87eg9j3vly.fsf@gnus.org> References: <20160502221340.17892.39911@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462296182 17527 80.91.229.3 (3 May 2016 17:23:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 May 2016 17:23:02 +0000 (UTC) Cc: Lee Bochicchio , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 03 19:22:48 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1axe24-0007LA-8K for ged-emacs-devel@m.gmane.org; Tue, 03 May 2016 19:22:48 +0200 Original-Received: from localhost ([::1]:42430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axe20-0003yx-GZ for ged-emacs-devel@m.gmane.org; Tue, 03 May 2016 13:22:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axe1g-0003mc-Tt for emacs-devel@gnu.org; Tue, 03 May 2016 13:22:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axe1V-0000ls-9s for emacs-devel@gnu.org; Tue, 03 May 2016 13:22:19 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:49689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axe1V-0000ij-3X for emacs-devel@gnu.org; Tue, 03 May 2016 13:22:13 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1axe1J-00016v-Of; Tue, 03 May 2016 19:22:03 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 03 May 2016 12:54:40 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203551 Archived-At: Stefan Monnier writes: >> + (let* ((table (obarray-make))) >> + (abbrev-table-put table :abbrev-table-modiff 42) >> + (should (abbrev-table-empty-p table)))) > > AFAIK this is a detail of the implementation, so I'm not sure we want to > test it. > I'd rather test > > (should (abbrev-table-empty-p (make-abbrev-table))) Ok; fixed now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no