From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ian Dunn Newsgroups: gmane.emacs.devel Subject: Re: Smie-auto-fill =?utf-8?Q?doesn=E2=80=99t?= respect comment-auto-fill-only-comments Date: Tue, 02 May 2017 21:14:39 -0400 Message-ID: <87efw62134.fsf@escafil> References: <87o9vdj0s5.fsf@tromey.com> <87mvavw0h5.fsf@pokyo> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493774173 13340 195.159.176.226 (3 May 2017 01:16:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 3 May 2017 01:16:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Tom Tromey , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 03:16:07 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5itd-000377-FY for ged-emacs-devel@m.gmane.org; Wed, 03 May 2017 03:16:01 +0200 Original-Received: from localhost ([::1]:34278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5iti-0006at-W1 for ged-emacs-devel@m.gmane.org; Tue, 02 May 2017 21:16:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5itb-0006an-Ue for emacs-devel@gnu.org; Tue, 02 May 2017 21:16:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5itb-0004Mr-7l for emacs-devel@gnu.org; Tue, 02 May 2017 21:15:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5itF-00047b-F4; Tue, 02 May 2017 21:15:37 -0400 Original-Received: from [2604:6000:1010:176:da4d:3352:bae5:f50e] (port=48428 helo=escafil) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d5itE-0001W8-Qr; Tue, 02 May 2017 21:15:36 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 02 May 2017 15:18:43 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214536 Archived-At: Stefan Monnier writes: > > But maybe a cleaner patch would change the C code so it doesn't (funcall > auto-fill-function) directly but instead it calls a fixed Elisp function > which does the comment-auto-fill-only-comments check and then funcalls > auto-fill-function. This would probably make it desirable to > move auto-fill-function from buffer.c to simple.el or fill.el. > I agree. It'd be easier for developers if the logic of comment-auto-fill-only-comments were dealt with outside of auto-fill-function. -- Ian Dunn