unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ian Dunn <dunni@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Tom Tromey <tom@tromey.com>, emacs-devel@gnu.org
Subject: Re: Smie-auto-fill doesn’t respect comment-auto-fill-only-comments
Date: Tue, 02 May 2017 21:14:39 -0400	[thread overview]
Message-ID: <87efw62134.fsf@escafil> (raw)
In-Reply-To: <jwv7f1zkrep.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Tue, 02 May 2017 15:18:43 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>
> But maybe a cleaner patch would change the C code so it doesn't (funcall
> auto-fill-function) directly but instead it calls a fixed Elisp function
> which does the comment-auto-fill-only-comments check and then funcalls
> auto-fill-function.  This would probably make it desirable to
> move auto-fill-function from buffer.c to simple.el or fill.el.
>

I agree.  It'd be easier for developers if the logic of
comment-auto-fill-only-comments were dealt with outside of auto-fill-function.

-- 
Ian Dunn



  reply	other threads:[~2017-05-03  1:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 12:04 Smie-auto-fill doesn’t respect comment-auto-fill-only-comments Nikolai Weibull
2017-04-23 19:31 ` Nikolai Weibull
2017-04-25  0:18   ` Ian Dunn
2017-04-30 16:52 ` Tom Tromey
2017-04-30 17:08   ` Stefan Monnier
2017-04-30 17:52     ` Stefan Monnier
2017-05-02 18:57       ` Tom Tromey
2017-05-02 19:18         ` Stefan Monnier
2017-05-03  1:14           ` Ian Dunn [this message]
2017-05-21 16:43           ` Tom Tromey
2017-05-21 21:03             ` Stefan Monnier
2017-05-22  6:24               ` Tom Tromey
2017-05-22 19:12                 ` Stefan Monnier
2017-05-29 21:20                   ` Tom Tromey
2017-05-30  3:25                     ` Stefan Monnier
2017-08-05 20:39                       ` Tom Tromey
2017-08-05 20:50                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efw62134.fsf@escafil \
    --to=dunni@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).