unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Putting 2fddfb7ce770f into emacs-26?
Date: Tue, 07 Nov 2017 18:29:06 -0800	[thread overview]
Message-ID: <87efp9y03x.fsf@ericabrahamsen.net> (raw)

I know it's a bit late in the day, but would it be okay to cherry-pick
61313f058c7a899c2fbce055d21 from master to emacs-26?

It's related to how EIEIO objects are written to file. Previously, the
written representation included a string label, which was later
obsoleted. Current emacs-26 code *assumes* the presence of a string
label: it discards it, but will fail without it.

The change in 61313f058c7a899c2fbce055d21 checks for the label and
conditionally ignores it, making the code more resilient when reading
objects written by a wider range of Emacs versions. A bit of
future-proofing.

Is that acceptable for emacs-26?

Thanks,
Eric




             reply	other threads:[~2017-11-08  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08  2:29 Eric Abrahamsen [this message]
2017-11-08 15:54 ` Putting 2fddfb7ce770f into emacs-26? Eli Zaretskii
2017-11-08 17:19   ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efp9y03x.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).