From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.devel Subject: Re: beginning-of-defun-comments bug [was: Re: 26.0.90: mark-defun problem in c-mode] Date: Sun, 07 Jan 2018 07:25:04 +0100 Message-ID: <87efn2fanz.fsf@mbork.pl> References: <834lo8fqyi.fsf@gnu.org> <20171230103432.GB10623@ACM> <20171230120136.GD10623@ACM> <83shbse5rs.fsf@gnu.org> <20171230130529.GE10623@ACM> <87incjh7ef.fsf@mbork.pl> <20180103162403.GB5435@ACM> <20180106120002.GA23284@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515306218 31295 195.159.176.226 (7 Jan 2018 06:23:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 Jan 2018 06:23:38 +0000 (UTC) User-Agent: mu4e 0.9.19; emacs 27.0.50 Cc: Eli Zaretskii , "emacs-devel@gnu.org" , "npostavs@gmail.com" , zhang cc To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 07 07:23:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eY4Mi-0007Vr-K8 for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 07:23:28 +0100 Original-Received: from localhost ([::1]:39961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eY4Oh-0006zH-RI for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 01:25:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eY4Ob-0006yb-E4 for emacs-devel@gnu.org; Sun, 07 Jan 2018 01:25:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eY4Oa-0007pT-KQ for emacs-devel@gnu.org; Sun, 07 Jan 2018 01:25:25 -0500 Original-Received: from mail.mojserwer.eu ([195.110.48.8]:51048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eY4OW-0007kk-Mc; Sun, 07 Jan 2018 01:25:20 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 012FBE6310; Sun, 7 Jan 2018 07:25:17 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BNRWWlRlD8ix; Sun, 7 Jan 2018 07:25:09 +0100 (CET) Original-Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 4B892E62DA; Sun, 7 Jan 2018 07:25:07 +0100 (CET) In-reply-to: <20180106120002.GA23284@ACM> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.110.48.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221654 Archived-At: On 2018-01-06, at 13:00, Alan Mackenzie wrote: > There was a long discussion about this and related matters on > emacs-devel about a year ago, I think. I'm assuming that this marking of > the preceding comment is in accordance with that thread on emacs-devel. More or less, yes. The rationale is that in many languages, the comment preceding the function is basically its docstring. Thus marking the function should also mark that comment. > I've committed the change to the emacs-26 branch. Thanks a lot for working on this. Best, -- Marcin Borkowski