From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 17:24:28 +0100 Message-ID: <87eflmte4j.fsf@gmail.com> References: <1775923222.898447.1518559575706@mail.libero.it> <83inb0xkfx.fsf@gnu.org> <87o9krdftc.fsf@gmail.com> <83a7wby1x4.fsf@gnu.org> <83r2pnwftj.fsf@gnu.org> <08ac43fb-0b13-8a51-4571-11a21b8ffbdc@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1518711841 25067 195.159.176.226 (15 Feb 2018 16:24:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 16:24:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 17:23:56 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emMK4-0005pY-IV for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:23:48 +0100 Original-Received: from localhost ([::1]:36341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emMM6-0005Kh-BG for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 11:25:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emML4-0005JC-Io for emacs-devel@gnu.org; Thu, 15 Feb 2018 11:24:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emML0-0002QB-H0 for emacs-devel@gnu.org; Thu, 15 Feb 2018 11:24:50 -0500 Original-Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]:35730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emML0-0002N4-9z; Thu, 15 Feb 2018 11:24:46 -0500 Original-Received: by mail-wr0-x229.google.com with SMTP id l43so245753wrc.2; Thu, 15 Feb 2018 08:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=1I4sZzGEtXH+VbJldpelvT9DdSap67WskPu6z+UiJTQ=; b=rV86Nl6Tq+GAmFgB4FcHwpz/B1xVML4cqBLySe1g3Etm0tKSXC0cFmJ5gz8Ki+s42+ aoAVBiDcmZV5REeYbBmn7xfQXaYf566jBq9IOYalTC2Qh1Y9MbW1Q7QlpkJs4bByzF2p pm9MDFw/DbAqbFp2Is+t40KLnul7buTyuCnFIclClRi2sE1/3lbQWQUIhK+BwfwCwviU WZOMSum4kYcWP5zxpZWYdqgOtxxIGl2cR0KOGAYQPWPTNpWrq5suGS7eW91tOFky/DIl Ag1rEcKzLlleSgQ4ITB/eQAlj5urNrCOvmr0dc4LZ6EWK7BaE41fyW07OfTP+UN0Vmzl IS3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=1I4sZzGEtXH+VbJldpelvT9DdSap67WskPu6z+UiJTQ=; b=T7NATZFc1Cm/ggCPz7s7O72eTPrjSVIpogQgDfepc2oen4ka+piHtmFiucB8EhlVzh wYTkf8W2hWPczGje2Pdfujsm0Yl76e65/ekvVlASF2edSfUPl54pW0qaxvFa6vCu24kc HqGdEQmyOxT6CwR4DCJltfNHtAB/3J3vTqi7uFT7fnxgYDbYOMwBsNIb3hm5g9nevS4R a6X3hX4N0r5aOn/ZMz9SSuS+bwhJyg5UEokhWpJuRnkjNWc6GHqoJJXp9sWhOjUk2sOP n+sQbQ36AGSCv5Ut9nsuT+IAq6N2lKvrfaROH/PajGEQCbu1U9ZHdVmAK6gWatRD8UpA kYwg== X-Gm-Message-State: APf1xPAxQNcPhX0gm0E1NEAwTqYW0St/oXtDKtRQ4pgc5mqv94Yfb0Hs Y+TfAorz2Qsui4k1VLQPprri8jqTu6Y= X-Google-Smtp-Source: AH8x224q73gqmywxz7OdtDsJb+9Wr3yK47KOld+g7ZINgBPnGHJAUlKxbwOOcPsEIV6oc9nR5fDsVQ== X-Received: by 10.223.173.18 with SMTP id p18mr3218402wrc.29.1518711884279; Thu, 15 Feb 2018 08:24:44 -0800 (PST) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id c14sm1268633wmh.2.2018.02.15.08.24.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 08:24:38 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <08ac43fb-0b13-8a51-4571-11a21b8ffbdc@dancol.org> (Daniel Colascione's message of "Wed, 14 Feb 2018 11:26:37 -0800") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222764 Archived-At: Daniel Colascione writes: > On 02/14/2018 11:07 AM, Eli Zaretskii wrote: >>> Cc: emacs-devel@gnu.org >>> From: Daniel Colascione >>> Date: Wed, 14 Feb 2018 09:49:49 -0800 >>> >>>> #3 0x01206274 in die ( >>>> msg=0x16ce7d2 "!pdumper_object_p (BEG_ADDR)", >>>> file=0x16ce674 "insdel.c", line=1937) >>>> at alloc.c:7789 >>>> #4 0x011acb8b in prepare_to_modify_buffer_1 (start=1, end=1, >>>> preserve_ptr=0x0) at insdel.c:1937 >>> >>> It's weird that we're failing there. If we're looking at a buffer with >>> dumped contents, we set b->text->beg to NULL, then use the normal >>> buffer-allocation procedure (whichever we're compiled to use) to >>> allocate memory for the contents. How can the resulting address ever be >>> equal to what we started with? Neither mmap_realloc nor r_re_alloc nor >>> xrealloc should ever reuse the address. >> >> You are talking about what enlarge_buffer_text does? IOW, this: > > It should be fixed now. Give it a shot. I'm not sure if this was meant for me as well. In any case, I just pulled and rebuilt, and everything seems to be working well as of commit 9484bb3ab8e39add474400e5982802b61c56eb3a (I'm using it to write this message). Robert