From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Let's make C-M-w in isearch yank symbol, not delete character Date: Sun, 04 Mar 2018 00:34:27 +0200 Organization: LINKOV.NET Message-ID: <87efl0pz4d.fsf@mail.linkov.net> References: <87po4slrg4.fsf@mail.linkov.net> <831sh82zyf.fsf@gnu.org> <87h8q2w29i.fsf@mail.linkov.net> <83tvu1zsru.fsf@gnu.org> <87tvtzjvh4.fsf@mail.linkov.net> <83tvtyx55a.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1520116417 5689 195.159.176.226 (3 Mar 2018 22:33:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Mar 2018 22:33:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: dancol@dancol.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 03 23:33:32 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1esFiZ-0008J4-OH for ged-emacs-devel@m.gmane.org; Sat, 03 Mar 2018 23:33:27 +0100 Original-Received: from localhost ([::1]:41945 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esFka-0006RB-38 for ged-emacs-devel@m.gmane.org; Sat, 03 Mar 2018 17:35:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esFkT-0006Qp-7h for emacs-devel@gnu.org; Sat, 03 Mar 2018 17:35:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esFkS-0000oY-Eg for emacs-devel@gnu.org; Sat, 03 Mar 2018 17:35:25 -0500 Original-Received: from hapkido.dreamhost.com ([66.33.216.122]:46592) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1esFkO-0000gM-BA; Sat, 03 Mar 2018 17:35:20 -0500 Original-Received: from homiemail-a76.g.dreamhost.com (sub3.mail.dreamhost.com [69.163.253.7]) by hapkido.dreamhost.com (Postfix) with ESMTP id AA4B190422; Sat, 3 Mar 2018 14:35:15 -0800 (PST) Original-Received: from homiemail-a76.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTP id EB87845807B; Sat, 3 Mar 2018 14:35:13 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-97-206.cust.tele2.ee [91.129.97.206]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a76.g.dreamhost.com (Postfix) with ESMTPSA id E99DC458079; Sat, 3 Mar 2018 14:35:12 -0800 (PST) In-Reply-To: <83tvtyx55a.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Mar 2018 10:17:53 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 66.33.216.122 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223250 Archived-At: >> Here is a new patch with the NEWS entry. Regarding the documentation, >> I'm pretty sure this is not the final implementation as there will be >> more changes in that feature before it's ready to be documented in >> (info "(emacs) Not Exiting Isearch") or in (info "(emacs) Isearch Yank= "). > > If this feature is good enough to be installed, it should be > documented. If there are later changes, the documentation should be > amended to reflect that. If nothing else, this makes sure we don't > forget to document it. Also, there are people who track the master > branch, and they will certainly benefit from having this documented. Done with documentation updates in the manual. Also I noticed that the value nil of search-exit-option is quite broken: it doesn't do anything useful. The manual says: "However, if you customize the variable =E2=80=98search-exit-option=E2=80= =99 to =E2=80=98nil=E2=80=99, the characters which you type that are not interpreted by the incremental search are simply appended to the search string. This is so you could include in the search string control characters, such as =E2=80=98C-a=E2=80=99, that would normally exit the search and invoke t= he command bound to them on the buffer." But the comment in isearch-pre-command-hook says: ;; If search-exit-option is nil, run the command without exiting Isearc= h. So it's not clear what it should do for e.g. motion commands: just move point without exiting Isearch or append control characters of motion keys to the search string?