From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: nesting eval-after-load? Date: Tue, 05 Jun 2018 12:37:56 -0700 Message-ID: <87efhlnhwr.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528227573 13483 195.159.176.226 (5 Jun 2018 19:39:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Jun 2018 19:39:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 05 21:39:29 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQHnj-0003Ni-Ac for ged-emacs-devel@m.gmane.org; Tue, 05 Jun 2018 21:39:27 +0200 Original-Received: from localhost ([::1]:48763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQHpq-0000dl-GL for ged-emacs-devel@m.gmane.org; Tue, 05 Jun 2018 15:41:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQHpH-0000dg-GG for emacs-devel@gnu.org; Tue, 05 Jun 2018 15:41:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQHpE-0005J2-GZ for emacs-devel@gnu.org; Tue, 05 Jun 2018 15:41:03 -0400 Original-Received: from [195.159.176.226] (port=54961 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQHpE-0005IP-8Y for emacs-devel@gnu.org; Tue, 05 Jun 2018 15:41:00 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fQHn3-0002cw-W9 for emacs-devel@gnu.org; Tue, 05 Jun 2018 21:38:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 32 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:+br/UaJ1msyOdYENK5qjZNmuGbU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226044 Archived-At: In Gnorb I've tried to make the various components (Org-focused, Gnus-focused, BBDB-focused) loadable separately, by protecting some setup with `eval-after-load'. In `gnorb-install-defaults' I tried to get clever and use nested `eval-after-load's, so that some keys are bound only if the user has elected to use, eg, *both* the Org and BBDB functionality. `gnorb-install-defaults' has bits in it like this: (eval-after-load "gnorb-bbdb" '(progn (define-key bbdb-mode-map (kbd "C-c S") #'gnorb-bbdb-mail-search) (define-key bbdb-mode-map (kbd "C-c l") #'gnorb-bbdb-open-link) (define-key bbdb-mode-map [remap bbdb-mail] #'gnorb-bbdb-mail) (eval-after-load "gnorb-org" (org-defkey org-mode-map (kbd "C-c C") #'gnorb-org-contact-link)))) This raises an error if the user loads "gnorb-org" and *then* "gnorb-bbdb". What seems to happen is that first the "gnorb-org" form is evaluated, and its return value (the function object `gnorb-org-contact-link') is stored in the outer `eval-after-load'. When "gnorb-bbdb" is loaded and the outer `eval-after-load' is evaluated, `gnorb-org-contact-link' is actually run as a function (and complains about wrong number of arguments). I had assumed that the entire outer `eval-after-load' form would remain "frozen" until "gnorb-bbdb" was loaded, at which point the inner `eval-after-load' would be evaluated and either define the key or "freeze" the inner form, depending. Is there a better way to do this? Thanks, Eric