From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: making xref.el a core ELPA package Date: Thu, 27 Dec 2018 17:59:27 +0000 Message-ID: <87efa2hmv4.fsf@gmail.com> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <65bd653b-bc09-035b-5f5e-4b7b32fe9c0e@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1545933508 25092 195.159.176.226 (27 Dec 2018 17:58:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Dec 2018 17:58:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Juri Linkov , emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 27 18:58:24 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcZvK-0006Iz-T7 for ged-emacs-devel@m.gmane.org; Thu, 27 Dec 2018 18:58:23 +0100 Original-Received: from localhost ([127.0.0.1]:54554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcZxR-0002IT-Ed for ged-emacs-devel@m.gmane.org; Thu, 27 Dec 2018 13:00:33 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcZwY-0002Gf-Lb for emacs-devel@gnu.org; Thu, 27 Dec 2018 12:59:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcZwU-0000Zc-H3 for emacs-devel@gnu.org; Thu, 27 Dec 2018 12:59:38 -0500 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:36599) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcZwU-0000X1-Am for emacs-devel@gnu.org; Thu, 27 Dec 2018 12:59:34 -0500 Original-Received: by mail-wm1-x331.google.com with SMTP id p6so18055473wmc.1 for ; Thu, 27 Dec 2018 09:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=KgDe7x8gS2sq281xCy68I6pelTFVYe5xJ8K16+7CWsA=; b=aibdEL+Zrx3WKuA2p02bffTE6+DLMxTRRHfRU3bzJ3J2mKQJK70guHs6zARSGVZNDG nlAih5QViNf7+FG+YNSOM55B9CXcgH6mQDZqjHCLZ1Efet6ZRgBRYb1TOpqQlU2mhWqZ lBytRqku0PQAz6sXC5X7NV3BDRo8RqkLIfhibbLB/yg7ytS72E0EemuzQue3DoDc10kv 7Oa2NCEBIT1Cg5cirdM0GCezIZ0pnH3rkNuuK4dqvIRFSerCJm6QpO3sVjsUzW4ksvAm foAMz2jPLeDWUy2VqYBGz8aFXA5AEv8dnh7WauRfXNzwP23TWohIvwpN2/BIq01JvmlK +uEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=KgDe7x8gS2sq281xCy68I6pelTFVYe5xJ8K16+7CWsA=; b=Sut5ZVM1D+9+1R4noZrFzmg3KDtTjAPVeXsvhmE4MZXzHjJeHCN45sLxyS8qQpLehM OxrMmV1CbQDULZDhlNuy1igH6vWW4tpw7RLynTQanRVGaBW2FWbXxT9Z7m5K4it8sQ83 huDsR+i+dkk8hWgwwEJ+MsRdazB3m66ayNkaLVGHj4LwZd1HYjSEhzzurKpokmgaRYmE gXjr4qSZjeM0JSIzkyP9PbL7V2QOGgt8QTh2p/LmSOvrTx+eu+3+nhOJDAKVsUPupabo fItoQF/EgQA3N3n6veRXuMtypmjytuusvQAfu1Cf8K+QDb51aKfpfB41iX8Xgyk/ojmd y7tw== X-Gm-Message-State: AJcUukcw5BVwbo5+NloRrz7HwRjCqvLztReOhjNpGFjelhgvwdePsJNc LH0PpEUriklR78xZzy1S65I= X-Google-Smtp-Source: ALg8bN4i+mPm3EqHJsEfJuywrnK4K2fLaj6FZ+/drnW3YpTv8NYm2uAMh5bn2X9W/qZU56Y5B+OzBw== X-Received: by 2002:a1c:ac85:: with SMTP id v127mr20037783wme.62.1545933570784; Thu, 27 Dec 2018 09:59:30 -0800 (PST) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id s1sm51083661wro.9.2018.12.27.09.59.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 09:59:29 -0800 (PST) In-Reply-To: <65bd653b-bc09-035b-5f5e-4b7b32fe9c0e@yandex.ru> (Dmitry Gutov's message of "Thu, 27 Dec 2018 03:12:02 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232004 Archived-At: Dmitry Gutov writes: > On 26.12.2018 16:48, Jo=C3=A3o T=C3=A1vora wrote: >> However here's a tangent that might affect the decision. >> Is there any impediment to making xref.el a core ELPA >> package? > > It *might* be as easy as adding the Version and Package-Requires tags > and then adding a :core entry to elpa/externals-list. > > Especially if you volunteer to test it in the previous release(es). We > definitely need cl-generic, though. So anything older than 26.1 is > out. Unfortunately, I just tested with 26.1 and no go. It doesn't have next-error-found :-( This is the commit: commit 0c9e3df3c2088b61feb4b4e00d24419459962273 Author: Juri Linkov Date: Tue Apr 17 22:27:48 2018 +0300 =20=20=20=20=20 Use next-error-found to set next-error-last-buffer. Either: * we revert this (I believe we shouldn't) * we use some indirection that is a no-op in 26.1 * we give up the idea >> I can see some advantages... > > Do you have anything specific in mind? Aside from simply getting new > features to the users faster. That would be it mostly :-) xref is a very important dependency of the Eglot LSP client, which could make it into core Emacs (and remain in ELPA as a :core package). There are some issues in Eglot that suggest new features could be useful: * https://github.com/joaotavora/eglot/issues/77 * https://github.com/joaotavora/eglot/issues/147 * https://github.com/joaotavora/eglot/issues/76 Also, I would like to see a pluggable API to control the insertion of xrefs into the *xref* buffer. Not only for LSP but also for SLY (a fork of SLIME where xref.el originated). Jo=C3=A3o