From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Merge-base alias for git vc-diff
Date: Wed, 02 Jan 2019 23:29:46 +0200 [thread overview]
Message-ID: <87ef9u951h.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvimz74yed.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Tue, 01 Jan 2019 20:55:34 -0500")
>> Since there is no good solution to reuse the existing command,
>> bug#33950 implements two new commands:
>>
>> * vc-log-mergebase (bound to ‘C-x v M L’) shows the same output as
>> GitLab shows in the “Commits” tab of the merge request.
>>
>> * vc-diff-mergebase (bound to ‘C-x v M D’) shows the same output as
>> GitLab shows in the “Changes” tab of the merge request.
>
> I must say I find this solution very unsatisfactory.
The reason I proposed separate commands is because I can't find
a good solution how to combine this with the existing commands.
Unsolved problems:
1. I don't know how to change the *Completions* buffer header from
“Possible completions are:” to
“Possible completions are (<REV>... means diff with common ancestor):”
2. How to support inserting a completion from the *Completions* buffer
into the minibuffer but not exiting the minibuffer after choose-completion.
Then after selecting a completion the user could add “...” to the end.
3. ‘C-u C-x v L’ asks for the limit only. Maybe adding a new prefix arg
‘C-u C-u C-x v L’ could ask for two revisions: start rev and end rev.
Then ‘C-u C-u C-x v D’ could also interpret its double prefix arg as diff
with the common ancestor.
next prev parent reply other threads:[~2019-01-02 21:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 22:32 Merge-base alias for git vc-diff Juri Linkov
2018-12-27 1:07 ` Dmitry Gutov
2018-12-27 20:02 ` Juri Linkov
2018-12-27 20:42 ` Dmitry Gutov
2018-12-28 17:53 ` Stefan Monnier
2018-12-29 21:39 ` Juri Linkov
2019-01-02 0:14 ` Juri Linkov
2019-01-02 1:55 ` Stefan Monnier
2019-01-02 15:34 ` João Távora
2019-01-02 22:25 ` Dmitry Gutov
2019-01-02 22:48 ` João Távora
2019-01-02 23:07 ` Dmitry Gutov
2019-01-03 3:22 ` Stefan Monnier
2019-01-03 13:30 ` João Távora
2019-01-03 20:38 ` Juri Linkov
2019-01-03 21:44 ` João Távora
2019-01-05 22:28 ` Juri Linkov
2019-01-07 22:33 ` Juri Linkov
2019-01-08 14:58 ` Stefan Monnier
2019-01-09 0:05 ` Juri Linkov
2019-01-02 21:29 ` Juri Linkov [this message]
2019-01-03 3:40 ` Stefan Monnier
2019-01-10 21:25 ` Juri Linkov
2019-01-10 22:14 ` Dmitry Gutov
2019-01-10 23:25 ` Juri Linkov
2019-01-10 22:41 ` Stefan Monnier
2019-01-10 23:18 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef9u951h.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).