Fwd: Re: Feedback on getting rid of `term-suppress-hard-newline'

[John Shahid <jvshahid@gmail.com>]

I just realized that my previous email was just to Stefan. Re-sending to
emacs-devel.

As I mentioned below, I noticed some missing logic when I was wrapping
up the final patch that was pushed to master a few days ago.  I fixed
the problem in the patch attached below.  Can someone please push it to
master.

Thanks,

JS

John Shahid <jvshahid@gmail.com> writes:

> Looks like I removed an important piece of logic when I reverted the
> removal of `(unless term-suppress-hard-newline...`.  The change seemed
> innocent enough, that I thought it didn't require testing.
>
> I added back the required logic in the attached patch.  Can you please
> install it ?
>
> Thanks,
>
> JS
>
> From d20013c6fdd9d84d216d77135f5ef012f8fb3f06 Mon Sep 17 00:00:00 2001
> From: John Shahid <jvshahid@gmail.com>
> Date: Tue, 26 Feb 2019 01:06:53 -0500
> Subject: [PATCH] Add text properties to newlines used to unwrap long lines.
>
> * lisp/term.el (term-emulate-terminal): do it.
> ---
>  lisp/term.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/term.el b/lisp/term.el
> index e759bb8e4f..693362cc73 100644
> --- a/lisp/term.el
> +++ b/lisp/term.el
> @@ -2935,6 +2935,7 @@ term-emulate-terminal
>                        (delete-region (point) (line-end-position))
>                        (term-down 1 t)
>                        (term-move-columns (- (term-current-column)))
> +                      (put-text-property (1- (point)) (point) 'term-line-wrap t)
>                        (setq decoded-substring
>                              (substring decoded-substring (- term-width old-column)))
>                        (setq old-column 0)))