From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 03 May 2019 15:14:50 +0100 Message-ID: <87ef5ffwv9.fsf@tcd.ie> References: <20190407181925.w3aztx44g5drtww2@Ergus> <83pnpx8y67.fsf@gnu.org> <20190407183806.htl4pujrb2kmk4kv@Ergus> <83mul18wpv.fsf@gnu.org> <20190407200514.2p6gfucdcdsrqe47@Ergus> <83ef6d8c40.fsf@gnu.org> <20190408085102.ozcuvs323ilfid7n@Ergus> <83bm1g8s02.fsf@gnu.org> <20190412134633.g47vybtpkwxyw7dq@Ergus> <834l73mir0.fsf@gnu.org> <20190501110808.27o64tawy2gyjocr@Ergus> <83sgtvn08w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="11375"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Ergus , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 03 23:17:53 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMfYq-0012u5-1G for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 23:17:40 +0200 Original-Received: from localhost ([127.0.0.1]:41310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMYy2-0004cb-JG for ged-emacs-devel@m.gmane.org; Fri, 03 May 2019 10:15:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMYxk-0004VV-JA for emacs-devel@gnu.org; Fri, 03 May 2019 10:14:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMYxj-0002bb-Mg for emacs-devel@gnu.org; Fri, 03 May 2019 10:14:56 -0400 Original-Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:42797) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMYxj-0002b4-G1 for emacs-devel@gnu.org; Fri, 03 May 2019 10:14:55 -0400 Original-Received: by mail-ed1-x52b.google.com with SMTP id l25so6177041eda.9 for ; Fri, 03 May 2019 07:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=PV+VaCVHS3bfU9ffGzrme6iCts2vtJgoAiDUaZqEvUA=; b=e4Qm0GKNKyQO9oPU/gsbvi7opxsHrVYFt8MSq2dOkPzWTvI1IcxsXKGzIkJh8mSiOv 9AxiffNGTzgjNmsjFPXxuetcN9BI9gu8jd73lGDQpyl3xqNd54MgijSCEZDVKio+CF2S ryMQnsYUMlvIg+yfQblbhr5MYifJO1tvES+vgp2j8j1s5FzdZiF376X8RDqsEjELa21L AOQrYAy+2l6MZ9Untq5NyUtMXdf/+9jUYCr4diKyJxhsLcwopNcLx9MDSA9Ah9vQRadT nv7P9BrjamKGPUM7TcRR9JrNlDFo+7IxlY7TZHdBoEbCjl5z4qQf6cCFGT6B7oeWo5zn 1o+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=PV+VaCVHS3bfU9ffGzrme6iCts2vtJgoAiDUaZqEvUA=; b=LYPmpV5P3nVqvZVKfUfkxvsKyleKPxXJyXRMScU4MXBUEW2O/Py/MsYJMYjiRlAK7k MnlKRUggrTzKA1m04kyNjmSXl/bgNAtYTBA7KralzEQh8BpuwiQc5ljizYioztkFw4w6 K43mFuJjHkP+u57ztmDg2CGBwxYrbDVq6BCGbyKRSMOvhr0dEoK+r16oOK0F5wfUav4W iSVWB/tipk6S5esjLDYbzCxLnnOYfOD3s4zXKKqsu8FClD0m4HAaVDgtjKfajOPSIXXK IDUiMwcaLNgGSRV1ZKr/AFTXTw4UUr4GXwLV6RYzvYJ/fqh3IMTyyLgiuxOpaRzjX+zA mIQQ== X-Gm-Message-State: APjAAAWaKdRiB8chvlMp5hoW4LndaHGFpDHG2nhJUvpeukGnpnNAYukI PXJmf936qkKNcimgAPg3PZ0zoQ== X-Google-Smtp-Source: APXvYqwrwZIt781Tmh1sxt62qdHpfmUsff8xMZPIJPUzT/dagzGmne9VIL8a9NjImLnuF2KhICIeww== X-Received: by 2002:a50:9b10:: with SMTP id o16mr2590127edi.229.1556892894075; Fri, 03 May 2019 07:14:54 -0700 (PDT) Original-Received: from localhost ([86.43.103.106]) by smtp.gmail.com with ESMTPSA id s11sm350922ejq.59.2019.05.03.07.14.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 03 May 2019 07:14:52 -0700 (PDT) In-Reply-To: <83sgtvn08w.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 3 May 2019 16:19:59 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236127 Archived-At: Eli Zaretskii writes: >> Date: Wed, 1 May 2019 13:08:08 +0200 >> From: Ergus >> Cc: emacs-devel@gnu.org >>=20 >> +@item fill-column-face > > This face should be indexed, use @vindex for that. [...] >> +;; Definition stolen from display-line-numbers. >> +(defface fill-column-face >> + '((t :inherit (shadow default))) >> + "Face for displaying fill column indicator line. > ^^^^ > I'd drop the "line" part. You allude to the shape of the indicator > character, but it doesn't have to look like a line, and using "line" > is confusing here. I'm not sure how closely this convention is followed in new code, but FWIW the defface docs under (info "(elisp) Defining Faces") say: -- Macro: defface face spec doc [keyword value]... This macro declares FACE as a named face whose default face spec is given by SPEC. You should not quote the symbol FACE, and it should not end in =E2=80=98-face=E2=80=99 (that would be redundant). ^^^^^^^^^^^^^^^^^^ Thanks, --=20 Basil