From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unit tests and lexical-binding for Tempo Date: Tue, 21 May 2019 15:30:59 +0100 Message-ID: <87ef4r7ucc.fsf@tcd.ie> References: <87h89yqiwu.fsf@gmail.com> <87k1etamhs.fsf@tcd.ie> <875zqcr9sm.fsf@gmail.com> <878sv1gnaf.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="85050"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Federico Tedin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 21 16:32:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hT5oK-000Lu0-VM for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 16:32:13 +0200 Original-Received: from localhost ([127.0.0.1]:54820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT5oJ-000696-Tw for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 10:32:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT5nH-00063m-IA for emacs-devel@gnu.org; Tue, 21 May 2019 10:31:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT5nG-0000r2-Lg for emacs-devel@gnu.org; Tue, 21 May 2019 10:31:07 -0400 Original-Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:32966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT5nG-0000q3-AT for emacs-devel@gnu.org; Tue, 21 May 2019 10:31:06 -0400 Original-Received: by mail-ed1-x52a.google.com with SMTP id n17so29785815edb.0 for ; Tue, 21 May 2019 07:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=c5D3/f/a9XuJpRlgKYO+Zy5jaaV4H3VijHukuh8hCV0=; b=Ie2tk88vn/M8kxaokK6A7NShqAQ6+DbAIAJJ9GSn6Ta6NfW029Ap5B/LXNoGWJa2nL zTqwSn8AqDDh+bpMdEjvN2rZQn5sdrAaEnjA4VGzRGmrczQtdYrd/jQTKsm6HUjYICd0 g0tNWvCU9UJB7OCkwN9kD4gWBw4YEDv/M5R179/SFfbbbXBAo0LBuvOKRq1SkuCdEP1y 3kJtfMiUlHGuVWOcOTPaH/bGH2q7ZYUvPiPZMO6BvW4WNEIzqAE+9LCsCJHJjfU1lpcf 0W7NWYFcuLsyH6qp8KzvorrOT3lNjfotB+8RxHY7j3GgmjFKxy8VATZp11tKU1aWp5zG zOFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=c5D3/f/a9XuJpRlgKYO+Zy5jaaV4H3VijHukuh8hCV0=; b=cGD45bCZINRTzeCQ730MnNWMNtFVzTtsf+4zVmID42h4LGea9XxRYYscSX+7zD9aiF L9/D6AURRCIRNJSKR7FZrWl1Qp4ArZa7mSLBI82NN1ZvGHLZtaAAVtlpoPF4fCjcUh+b Drwd9QD5SNvQfc4TKSEQycMDBSrX95G5pMJum2r6mPmRycmqLiiSDMMXhsgd2MjtaBBb SxO9VI/f6qnCLWNiRQcZYCQbfxmxxzQFyPIxpovo0K3GIq96dglqVvdccrwRot2lZqGG D7r4+FWAqtdJ8rSdLTTRHs9JFb06LuSHUjCIX9luYOIVxY1Rj5DH2SQzGYAUZ435TxmY M0Gg== X-Gm-Message-State: APjAAAXvZV6RWMjWhIxBA0mpISphpl7f5UB5Y1AhraYhZ5MzDxRiH9J+ zsGS0gCfOIGpKpKa4d+YCUSRlw== X-Google-Smtp-Source: APXvYqxnmKgiG6916cRCf167rOmO7xoH2UrYDIjC3ZxVJqV7CBbGsDbt0cR5D7EyKvj+LYlTW+JDCQ== X-Received: by 2002:a50:8dc5:: with SMTP id s5mr55347460edh.138.1558449064915; Tue, 21 May 2019 07:31:04 -0700 (PDT) Original-Received: from localhost ([82.141.252.179]) by smtp.gmail.com with ESMTPSA id fk5sm3629561ejb.28.2019.05.21.07.31.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 21 May 2019 07:31:04 -0700 (PDT) In-Reply-To: (Federico Tedin's message of "Mon, 20 May 2019 16:32:24 -0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236858 Archived-At: Federico Tedin writes: > Good catch, sorry about that. The correct header should use "Federico > Tedin ", like you mentioned. No worries. I took the liberties of extending the commit message to reference this discussion and mention the other variables which were switched to defvar-local, and shortening the docstring of tempo-tempo-user-elements-test to more closely follow the conventions in (info "(elisp) Documentation Tips"), and pushed to master[1]. Let me know if I messed anything up. [1: eb2e9a2ca2]: Use lexical-binding in tempo.el and add tests 2019-05-21 15:23:23 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eb2e9a2ca29f7d5e3b97709e9eca14fa5556ac63 Thanks, -- Basil