From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: On elisp running native Date: Fri, 06 Mar 2020 15:15:16 -0600 Message-ID: <87eeu5jicb.fsf@alphapapa.net> References: <83sgl0lchm.fsf@gnu.org> <83imlwl9vm.fsf@gnu.org> <83o8uegykm.fsf@gnu.org> <74dd94a9-28cb-a5fd-dbc7-ab21009834ad@cs.ucla.edu> <87mu8vjcmm.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="15577"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 06 22:16:58 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAKL2-0003vP-Ua for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Mar 2020 22:16:56 +0100 Original-Received: from localhost ([::1]:42348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAKL1-0003WD-Vd for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Mar 2020 16:16:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57066) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAKJb-0002Oa-8d for emacs-devel@gnu.org; Fri, 06 Mar 2020 16:15:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAKJa-0003Oy-7F for emacs-devel@gnu.org; Fri, 06 Mar 2020 16:15:27 -0500 Original-Received: from ciao.gmane.io ([159.69.161.202]:36784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jAKJa-0003Mn-0y for emacs-devel@gnu.org; Fri, 06 Mar 2020 16:15:26 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jAKJX-00025r-QL for emacs-devel@gnu.org; Fri, 06 Mar 2020 22:15:23 +0100 X-Injected-Via-Gmane: http://gmane.org/ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 159.69.161.202 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245294 Archived-At: Hi Andrea, Andrea Corallo writes: >> To work around it, I wrapped (defvar org-ql-predicates...) in >> eval-and-compile, and then wrapped all of the calls to org-ql--defpred >> in eval-and-compile as well. Then I deleted the org-ql.eln file and >> recompiled it, restarted Emacs, and then everything worked fine. >> >> I'm guessing that this issue is "native" to the native-compilation and >> might need to be documented in some way, but I wouldn't expect it to >> affect many packages, only ones that do tricky things with variables and >> macro-expansion like this. > > This is strange. The semantic of the native compiled code should be > exactly the same of the byte-compiled one. I may look at this in the > weekend if I manage to. Thanks for reporting. FYI, I pulled the new Docker image, the one that does create the arch-specific directories for the ELN files, then I installed org-ql again, without those modifications, and I didn't get that error again, and it seems to be working fine. So hopefully it was either a fluke or something fixed by your latest changes. One small issue I noticed: While working on another package, I caused a segfault when calling edebug-defun. I restarted Emacs and wasn't able to reproduce it, and I continued using Edebug on that and other code without any crashes. I also noticed some other unusual behavior with Edebug while stepping through an Edebugged function (pressing "g" did not skip to the next breakpoint, instead it seemed to behave like "n"), and I doubt that has anything to do with the native-comp branch, so maybe the segfault doesn't either. Thanks again for all your work on this.