From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: dash.el [was: Re: Imports / inclusion of s.el into Emacs] Date: Sat, 23 May 2020 01:48:16 +0100 Message-ID: <87eerbwk6n.fsf@gmail.com> References: <96bf0b6e-3559-ed02-5596-6a6642188309@yandex.ru> <93a7bb1c-390f-440f-02cc-6cce39ea9431@yandex.ru> <87k1175sl3.fsf@gmail.com> <2a43cea0-8e00-3c22-3ddc-eff29fc9b2db@yandex.ru> <87d06y4kze.fsf@gmail.com> <712d7134-b8ef-b843-bb20-152717092497@yandex.ru> <87367s1bxu.fsf@gmail.com> <90325e25-7a44-0068-9294-91afda7ed953@yandex.ru> <87pnawyr9t.fsf@gmail.com> <87mu5zyctg.fsf@gmail.com> <58e1a8c7-59a7-b9dd-7260-726d3e137927@yandex.ru> <871rnby0kz.fsf@gmail.com> <89cc0eec-ebaa-1605-9f10-52fdf7140322@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35114"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: Richard Stallman , joostkremers@fastmail.fm, emacs-devel , "Alfred M. Szmidt" , Stefan Monnier , =?utf-8?B?7KGw7ISx67mI?= , Eli Zaretskii , Phillip Lord To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 23 02:48:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcILM-00092n-NY for ged-emacs-devel@m.gmane-mx.org; Sat, 23 May 2020 02:48:52 +0200 Original-Received: from localhost ([::1]:57040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcILL-0006VI-PQ for ged-emacs-devel@m.gmane-mx.org; Fri, 22 May 2020 20:48:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcIKt-0005xF-3v for Emacs-devel@gnu.org; Fri, 22 May 2020 20:48:23 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:38366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcIKr-0003hJ-S4; Fri, 22 May 2020 20:48:22 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id e1so11957582wrt.5; Fri, 22 May 2020 17:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=y5XV5jxKxg4ZAFWYXtoxeRnFmo0Z+TTr7gbO4ao2tRo=; b=rq/2WP7Wser2DY8yyaNSJXe79IF4bsrfukXf/FSrt4Tfkn3EADDz5tP6XWpFQBORge Z781l6+UPoY/ky00SaxbjQLcbC8vo530G8BszRdmUhTwmDHJ8G1s1Fbg1IzSW3PLVmkt EFg/iTx9c+4Q/FYKSjA0yN1e9UW9n9Z9bjnpVbGmE2ZviDe+GXtcqj9+vS5+GMqECu22 R5cBqXJxMARzrdXrebXajiexrJR2v3AJ+Yq7jFWJBi+nSfp63oVWY3CmOyFXATIwEN14 G9zIpOT0WgTnp1/6meAkjsxEsvbeX2wHwPK1rOcNTWq4jsE4WpUgpHS/RZpj0S4u1rXc YS7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=y5XV5jxKxg4ZAFWYXtoxeRnFmo0Z+TTr7gbO4ao2tRo=; b=L1HvBG+o1a8WOIHni/4Hyl0Lzhu+eZsCuws+TBwSNxfuZUze5uzL+UJQoP3Z0mxUNi ZKqxkHa+ovZ7I8bT38VbLrzMpQ9680PUDVF1TJt/1FdiiG0vyyzzCOeFHcnyRjHF5Gt0 2O1xkt9mlSx95SOl1Sruyl4kV4kGjFBOGU9bM0EetjhkxZodiPnG2Wimicoctlnh+Q9W s5bNXroQXB/FQ4wh5XmtMcsG8XbSyA2v+/Dr2hoYZ+Ee9Vk/E8I8hfcbj4Giebx8bfkW Y07qkeQTkjQUHQzDBkzcXSBba+yaYDkT7GcRSXpDi4/46LjO1/cjjN+/G6bT1bXXYMCQ m97w== X-Gm-Message-State: AOAM530HOTiRUTyxW8Bzu939CdlTl7ILaiRUwH7vHf4Qx3Gmi5bc2Tzo GWpsrQbRNdi45WtF7NRNmTd/xOZbI2bY1g== X-Google-Smtp-Source: ABdhPJwe3Pk1pYSrEUhc5A2Iihh7Czz2b8tqhI5np8n/ShAjnRxocZ69wA9kdAnN3UczCFX7jLkAwA== X-Received: by 2002:a5d:5445:: with SMTP id w5mr5210569wrv.422.1590194898689; Fri, 22 May 2020 17:48:18 -0700 (PDT) Original-Received: from krug ([2001:818:d820:9500:824a:171:15a:2213]) by smtp.gmail.com with ESMTPSA id l19sm11352191wmj.14.2020.05.22.17.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 17:48:17 -0700 (PDT) In-Reply-To: <89cc0eec-ebaa-1605-9f10-52fdf7140322@yandex.ru> (Dmitry Gutov's message of "Sat, 23 May 2020 03:24:49 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x429.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251254 Archived-At: Dmitry Gutov writes: > On 23.05.2020 03:08, Jo=C3=A3o T=C3=A1vora wrote: >> Dmitry Gutov writes: >>=20 >>> I don't think that's what "integrated" means. >> Why not? You find the Rust file, activate Eglot and it starts >> working. >> Some major modes might even automate the second step, if it's cheap. I >> know people really like `eglot-ensure`, which that starts up a server >> automatically. > > It's less "integrated" than what that other mode is doing. I don't see how. We must be talking about different things. I'm talking Emacs -Q, C-x C-f foo.xxx RET and xxx-mode kicks in, sets up and maybe even starts Eglot. For that to work, xxx-mdoe has to be in core, otherwise you need M-x package-install xxx-mode > So worst case scenario, people will point out that Emacs core has > released something not entirely complete while there is a package with=20 > all batteries included. You're saying this becasue rust-mode isn't in the core and/or GNU ELPA? Than it's not a problem of Eglot/LSP at all.=20=20 > Again, examples of much simpler programs. And historically stable. And > Rubocop has its own, well-documented configuration interface (text > file) that's expected to be edited by users. Don't see any reson why an LSP server would be some kind of second-grade delinquent program. > And of every major mode author making the effort to familiarize > themselves with this stuff, apparently. Same with font-lock and imenu and eldoc and forward-sexp-function. Mode authors needn't familizarize themselves with the protocol, only in some cases with the server program they're setting up. Like rubocop. > You might be forgetting that Eglot doesn't exactly support _all_ the > features that languages servers offer. At least, that's my impression > of your answer to the question about refactoring actions. Eglot supports refactoring actions. Commands and renames and stuff . I don't know what where you want to go with this. Give an example. If Eglot doesn't support something we can add it. LSP works by "capability", what capability are you exactly referring to? And not all servers support the same capabilities. > And take the lsp-rust example again: > https://github.com/emacs-lsp/lsp-mode/blob/057e8789638a0bf493930637185694= b6b09ea58e/lsp-rust.el#L259-L283 > > There are 24 settings there. Yuck. Well they seem to be doing stuff that rust-mode could do in aone of Eglots variables and a generic function. I think you should acquaint yourself with Eglot and some of these servers, and then bring specific problems, here or to the tracker. I or some other member of the team will be happy to answer. Else we're just speaking in the abstract, you trying to convince me that something somewhere someday is not going to work. Jo=C3=A3o