From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: gnus-server-to-method crash on virtual server name in gnus-secondary-select-methods Date: Fri, 08 Jan 2021 10:28:52 -0800 Message-ID: <87eeivwae3.fsf@ericabrahamsen.net> References: <24567.20346.37031.450073@lwm.klanderman.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18492"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Greg Klanderman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 08 19:29:51 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxwWE-0004jM-SG for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jan 2021 19:29:50 +0100 Original-Received: from localhost ([::1]:45332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxwWD-0008Po-U4 for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jan 2021 13:29:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxwVV-0007yo-2v for emacs-devel@gnu.org; Fri, 08 Jan 2021 13:29:05 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:45574 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxwVT-00015b-5v for emacs-devel@gnu.org; Fri, 08 Jan 2021 13:29:04 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 0D682FA013; Fri, 8 Jan 2021 18:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1610130534; bh=iQwBXqu268017fA2uC+dvDMgryUBEy9LYcrbHihhgoc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PAeysONsZBnqyteVzormChuHYRWH9JxqvAmfkaEzsWgLTjtOpfhIX/81psKud9t0G RB12Ql1n8Fr/Sodvvz5QhdaELmCqlJXjn2QsQ0oWWJoRTQV14EkK3H7lgJmCnJkrVw Zw6UiKkUGGSGUbas2rI/bclMEl9/JvysExQI4SRY= In-Reply-To: <24567.20346.37031.450073@lwm.klanderman.net> (Greg Klanderman's message of "Thu, 7 Jan 2021 13:14:18 -0500") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262768 Archived-At: Greg Klanderman writes: > Hi, hopefully this is the correct list for reporting Gnus problems > these days; I see there is also info-gnus-english@ but it doesn't look > terribly active. > > Not subscribed so please include me in replies. > > I'm a long time Gnus user since early/mid 90's, and was fairly active > reporting problems back then (still listed in 'Contributors'!). Welcome back! > I have recently transitioned my email from nnfolder to nnmaildir as I > ran up against 1Gb group file size limit (still on XEmacs 21.4 and > Gnus 5.10.8). > [...] > Anyway, in the process of this transition, I found that when I put my > new nnmaildir server, named "mail" before '(nnfolder "") in > gnus-secondary-select-methods, it crashes on startup in > gnus-server-to-method. Since that code looks the same in emacs 21.7 / > Gnus 5.13 it seemed warranted to report the issue. > > In detail: I still have some legacy nnfolder groups (old groups that > are no longer delivered to). On startup, gnus-read-active-file loops > over gnus-secondary-select-methods, and when the nnfolder appears > second, Gnus has not yet opened the nnfolder server when > gnus-read-active-file-1 is (first) called with the nnmaildir and loops > over infos, calling gnus-find-method-for-group, in turn calling > gnus-server-to-method for one of the nnfolder groups > (gnus-server-to-method is called with "nnfolder:"). > > In that function, this code (unchanged in 5.13 / Debian testing emacs-gtk): > >;; It could be a named method, search all servers > (let ((servers gnus-secondary-select-methods)) > (while (and servers > (not (equal server (format "%s:%s" (caar servers) > (cadar servers))))) > (pop servers)) > (car servers)) > > is not handling the fact that gnus-secondary-select-methods may > contain virtual server name strings (only handling select methods, > assuming it can take car/cdr of elements). Okay, I'm not 100% parsing the above. I think I understand the fundamental issue: on startup, when Gnus is looping over all infos and categorizing them by select method, it barfs somehow when checking if an info belongs to your nnfolder server, because it somehow can't look up the server. Because... it's a string name, not a (list) method? I'm not sure. Can you show your complete config for `gnus-secondary-select-methods'? I don't think you're supposed to be able to define a server as a plain string. I have left your other asides aside! While this is a fine place to raise general Gnus questions/issues (the gnus.general group would be another option), if you have a very specific problem or feature request you'd like to make, I would recommend just opening a bug report. Lars is watching those pretty closely. Also, upgrade your Emacs :) Eric