From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: POLL: make C-x o transient Date: Mon, 25 Jan 2021 19:01:48 +0200 Organization: LINKOV.NET Message-ID: <87eei9xb5r.fsf@mail.linkov.net> References: <2EFBBE54-62F4-4373-82D6-DC8750B648BA@kuaishou.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24710"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: "condy0919@gmail.com" , Zhiwei Chen , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 25 18:13:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l45Qg-0006L7-0G for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Jan 2021 18:13:30 +0100 Original-Received: from localhost ([::1]:54748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l45Qe-0006Dk-St for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Jan 2021 12:13:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l45MH-0002ln-W2 for emacs-devel@gnu.org; Mon, 25 Jan 2021 12:08:58 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:54781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l45MF-0006lX-Sb for emacs-devel@gnu.org; Mon, 25 Jan 2021 12:08:57 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id A27D540012; Mon, 25 Jan 2021 17:08:50 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Mon, 25 Jan 2021 09:39:00 -0500") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263397 Archived-At: >> Which will make `C-x o` invoke a transient version of `other-window' >> like `text-scale-adjust’ does. > > I think the pattern is clear: `C-x ` are good candidates ;-) And non-letters too, especially `C-x {`, `C-x }`, `C-x ^`, ... need to be repeatable. I'm using such quite messy blob of code, it would be nice if someone would generalize this mess without using advice-add. #+begin_src emacs-lisp (defvar window-command-keymap (let ((map (make-sparse-keymap))) ;; Standard keys: (define-key map "0" 'delete-window) (define-key map "1" 'delete-other-windows) (define-key map "2" 'split-window-below) (define-key map "3" 'split-window-right) (define-key map "o" 'other-window) (define-key map "^" 'enlarge-window) (define-key map "}" 'enlarge-window-horizontally) (define-key map "{" 'shrink-window-horizontally) (define-key map "-" 'shrink-window-if-larger-than-buffer) (define-key map "+" 'balance-windows) ;; Additional keys: (define-key map "v" 'shrink-window) (define-key map [down] 'shrink-window) (define-key map [up] 'enlarge-window) (define-key map [left] 'shrink-window-horizontally) (define-key map [right] 'enlarge-window-horizontally) map) "Keymap for commands that operate on windows.") (advice-add 'enlarge-window-horizontally :after (lambda (&rest _args) (set-transient-map window-command-keymap))) (advice-add 'shrink-window-horizontally :after (lambda (&rest _args) (set-transient-map window-command-keymap))) (advice-add 'enlarge-window :after (lambda (&rest _args) (set-transient-map window-command-keymap))) (advice-add 'shrink-window :after (lambda (&rest _args) (set-transient-map window-command-keymap))) (defun window-command-prefix () (interactive) (message "Use window prefix keys...") (set-transient-map window-command-keymap)) (define-key ctl-x-map "wr" window-command-prefix) ;; (define-key window-command-keymap [digit-argument] 'ignore) ;; (define-key window-command-keymap [universal-argument] 'ignore) ;; (define-key window-command-keymap [?\C-u] 'universal-argument) #+end_src