From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 15:18:59 +0000 Message-ID: <87eeg2c598.fsf@tcd.ie> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <8735wj3ajh.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Stefan Monnier , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 16:20:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPoFu-0003vC-Px for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 16:20:10 +0100 Original-Received: from localhost ([::1]:39968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPoFt-0004dC-Q9 for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 11:20:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPoEt-0003QR-Pm for emacs-devel@gnu.org; Fri, 26 Mar 2021 11:19:07 -0400 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:45781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPoEr-0008FM-1A for emacs-devel@gnu.org; Fri, 26 Mar 2021 11:19:07 -0400 Original-Received: by mail-wr1-x435.google.com with SMTP id j9so4277115wrx.12 for ; Fri, 26 Mar 2021 08:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UbHVPlRBt5gcfOW1jIEzX5iP9UA5nx3AiJx520QaJQw=; b=V+eJ3FCpur5fFXQGZL1QSIVCsQCUDwEiSPiIweXHUtGvC988FxRG/vgpDFDuDSJkhu cAJaDZH5klTfl0vMTJgVkOHT0sTbnszdg2UTXBdLOEtKS8+joYszmZNmGp3OyUbA608u Tnl+UJVO5OurDBsHW2GPMNFoxr0oBBiV5m25wdls7K9mK8pDaO3Nv37dDfeZ0D5G9YFJ 9RdHC4uNYnamWo3nSz45zdA7jAm34rjahK2z5Hkb77gdT7UA2O0R+zofNjduziG0M70l w8heLkTJUZwhQ12bhExSaka0rx3tg6j/+/MGfJuEOJeBQkuopikcyU2Me/awKCmd0QQL Bkmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UbHVPlRBt5gcfOW1jIEzX5iP9UA5nx3AiJx520QaJQw=; b=nID2IqD34aMqzr+9f6iyafHAaUgri/j0jciwK6zEKp/2ZjinNU567OuLcUGnwUs/um b92jR7DOF7Tu76KsfzGeQp1i2nwx/jDTeOGgHXXWq3lvmmwStmrmI7Z3RiiZJIUgumT9 oGFGGFeYDKvNYD6KPr4QuPcJ9JTLB0nUlPGN9LGvayc4HRpFZCr1dCb/Z3IjrfRO8Bx8 jzRYTVUNz2ONA4KXjTZiRMZS4OFnGENnzLiDlE0fpEghbKdB3MLkF4qnqUAPk/q226Xk C31t7zR6TA8M+4+R0HuMYDQ63jmTXHbD7gF7wHHM29j1AUWvtM9weyMad+PBfmxhYa9C ON2A== X-Gm-Message-State: AOAM531oHidaITfJf6Zgbiql8SRjp3DTtT7Hu2xl91I1XPFXAgtzJDjt iy4UJEwPQAC8Sy2kefNjHZ2e/w== X-Google-Smtp-Source: ABdhPJxP2UuIxhSqpIM1FVmuEGxBZrvD3ZjY9uA8PAlTtn8mG2fRkgh8ebxsbNJtoFJYxbh3MSmoAQ== X-Received: by 2002:a5d:6443:: with SMTP id d3mr15255948wrw.292.1616771941244; Fri, 26 Mar 2021 08:19:01 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id m10sm11645223wmh.13.2021.03.26.08.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 08:19:00 -0700 (PDT) In-Reply-To: <8735wj3ajh.fsf@gmx.de> (Michael Albinus's message of "Thu, 25 Mar 2021 09:25:06 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=contovob@tcd.ie; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267073 Archived-At: Michael Albinus writes: > "Basil L. Contovounesios" writes: > >> + ;; Demote any errors so M-x continues to work. >> + (condition-case-unless-debug err >> + (funcall (get symbol 'completion-predicate) symbol buffer) >> + (error >> + (message "command-completion-default-include-p: %s: %S" symbol err) > > I would also report buffer. That's what I had initially, but I found it a bit noisy since the buffer is usually the current one (at least in the read-extended-command case for sure). > Otherwise, it LGTM (but I'm not Lars :-) Thanks, -- Basil