From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Sat, 10 Apr 2021 23:56:57 +0300 Organization: LINKOV.NET Message-ID: <87eefhevye.fsf@mail.linkov.net> References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> <87im4z1gbc.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27027"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 23:54:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVLYX-0006uV-2A for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 23:54:17 +0200 Original-Received: from localhost ([::1]:59202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVLYW-0001QJ-3M for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 17:54:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVLXL-0000vy-HN for emacs-devel@gnu.org; Sat, 10 Apr 2021 17:53:03 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:47307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVLXJ-00065n-Gc; Sat, 10 Apr 2021 17:53:03 -0400 X-Originating-IP: 91.129.96.157 Original-Received: from mail.gandi.net (m91-129-96-157.cust.tele2.ee [91.129.96.157]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 74B4F1C0005; Sat, 10 Apr 2021 21:52:52 +0000 (UTC) In-Reply-To: (Gregory Heytings's message of "Tue, 06 Apr 2021 20:09:56 +0000") Received-SPF: pass client-ip=217.70.183.197; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267837 Archived-At: >> The only problem I see this code is too hackish: > > It is (a bit) hackish because the output of icomplete-completions is (a > bit) hackish. Good to see that the new branch avoids such hacks. I tested it out, and everything is nice. After using it a while I noticed that one useful feature is missing, but it could be added later to not prevent merging the current version to master now. What is missing is the scrolling commands that could be bound to C-v and M-v to scroll completions. For the simplest implementation, this means just to call icomplete-forward-completions N times where N is the height of the displayed completions list.