From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Why does Gnus article-moving act like a fetch of new news? Date: Mon, 12 Apr 2021 10:05:53 -0700 Message-ID: <87eeffsaa6.fsf@ericabrahamsen.net> References: <87lf9rruzl.fsf@red-bean.com> <87wnt824dq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18102"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Karl Fogel , Emacs Development To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 12 19:09:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lW03h-0004Yq-E3 for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Apr 2021 19:09:09 +0200 Original-Received: from localhost ([::1]:48932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lW03g-0004x4-FD for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Apr 2021 13:09:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lW00o-0003lf-UY for emacs-devel@gnu.org; Mon, 12 Apr 2021 13:06:11 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:41150 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lW00c-0007KE-7N for emacs-devel@gnu.org; Mon, 12 Apr 2021 13:06:06 -0400 Original-Received: from localhost (c-71-197-184-122.hsd1.wa.comcast.net [71.197.184.122]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 1AA3AFA099; Mon, 12 Apr 2021 17:05:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1618247155; bh=ZFw6vSDqcweR05q9uYhbCBFg3r3nXNxTutsVaAVoLGE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EGIxMKIelBTiCOfp9IDgvVOegn1SRN+T8zkatUAskxOinRjYu0UT/o0anpVPOxoNF 7OZqH8J32VyAkFCPEvY+iL0eEEZZ64kdXS1SoeOgRwENtMMvTmWk/2syYOKD5tAw3D s4Zc9EiLguTqjiXiScbSm9PhoYiVmcMOLuUD8qnI= In-Reply-To: <87wnt824dq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 11 Apr 2021 18:05:37 +0200") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267969 Archived-At: Lars Ingebrigtsen writes: > Karl Fogel writes: > >> In lisp/gnus/gnus-sum.el, at the end of `gnus-summary-move-article', >> there is this code: >> >> ;; Re-activate all groups that have been moved to. >> (with-current-buffer gnus-group-buffer (let >> ((gnus-group-marked to-groups)) >> (gnus-group-get-new-news-this-group nil t))) I'm no expert in >> this area of the code, but the above seems to conflate two >> different things: >> >> a) It tells the destination group(s) that a new article has arrived, >> and I guess that in turn "activates" the group? (My understanding >> of activation in Gnus is somewhat fuzzy.) > > The code has been in there since the command was added (in 1997), > apparently... I think it's just supposed to update the number of > articles in the group buffer? So maybe `gnus-activate-group' would be sufficient? Though it looks like the number-of-articles update is happening at line 10271, anyway. Karl, would you be willing to patch the function to replace `gnus-group-get-new-news-this-group' with `gnus-activate-group', and run that for a while and see if anything terrible happens?