From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Karl Fogel <kfogel@red-bean.com>,
Emacs Development <emacs-devel@gnu.org>
Subject: Re: Why does Gnus article-moving act like a fetch of new news?
Date: Mon, 12 Apr 2021 10:05:53 -0700 [thread overview]
Message-ID: <87eeffsaa6.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87wnt824dq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 11 Apr 2021 18:05:37 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Karl Fogel <kfogel@red-bean.com> writes:
>
>> In lisp/gnus/gnus-sum.el, at the end of `gnus-summary-move-article',
>> there is this code:
>>
>> ;; Re-activate all groups that have been moved to.
>> (with-current-buffer gnus-group-buffer (let
>> ((gnus-group-marked to-groups))
>> (gnus-group-get-new-news-this-group nil t))) I'm no expert in
>> this area of the code, but the above seems to conflate two
>> different things:
>>
>> a) It tells the destination group(s) that a new article has arrived,
>> and I guess that in turn "activates" the group? (My understanding
>> of activation in Gnus is somewhat fuzzy.)
>
> The code has been in there since the command was added (in 1997),
> apparently... I think it's just supposed to update the number of
> articles in the group buffer?
So maybe `gnus-activate-group' would be sufficient? Though it looks like
the number-of-articles update is happening at line 10271, anyway.
Karl, would you be willing to patch the function to replace
`gnus-group-get-new-news-this-group' with `gnus-activate-group', and run
that for a while and see if anything terrible happens?
next prev parent reply other threads:[~2021-04-12 17:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 21:47 Why does Gnus article-moving act like a fetch of new news? Karl Fogel
2021-04-10 4:11 ` Eric Abrahamsen
2021-04-10 4:58 ` Karl Fogel
2021-04-10 5:29 ` Eric Abrahamsen
2021-04-10 8:29 ` Andreas Schwab
2021-04-10 13:06 ` Stefan Monnier
2021-04-10 22:00 ` Eric Abrahamsen
2021-04-11 6:02 ` Karl Fogel
2021-04-11 16:05 ` Lars Ingebrigtsen
2021-04-12 17:05 ` Eric Abrahamsen [this message]
2021-04-12 17:56 ` Karl Fogel
2021-04-12 18:26 ` Eric Abrahamsen
2021-04-13 20:25 ` Karl Fogel
2021-04-13 21:59 ` Eric Abrahamsen
2021-04-14 3:27 ` Karl Fogel
2021-04-25 17:37 ` Lars Ingebrigtsen
2021-05-03 20:52 ` Eric Abrahamsen
2021-05-03 20:53 ` Eric Abrahamsen
2021-05-05 23:21 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeffsaa6.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).