From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Tue, 18 May 2021 11:49:34 +0100 Message-ID: <87eee42u69.fsf@tcd.ie> References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Karl Fogel , "Paul W. Rankin" To: "Paul W. Rankin" via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 18 12:51:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lixKC-0006wo-W9 for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 12:51:45 +0200 Original-Received: from localhost ([::1]:34756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lixKB-0002ha-Kt for ged-emacs-devel@m.gmane-mx.org; Tue, 18 May 2021 06:51:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lixIC-0000wc-Ge for emacs-devel@gnu.org; Tue, 18 May 2021 06:49:41 -0400 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:40944) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lixI9-0006nY-DH for emacs-devel@gnu.org; Tue, 18 May 2021 06:49:40 -0400 Original-Received: by mail-wm1-x32d.google.com with SMTP id f6-20020a1c1f060000b0290175ca89f698so1228182wmf.5 for ; Tue, 18 May 2021 03:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iUblFBDSbSYaBc0dVFljstq0lO5uBzNiwyO+b0dk7GI=; b=EClQ3aOqvGrN1HK51BEZ3tgEf8q3105y7NpfSCi+GBX+NBczyebpSP7woDqRItc/Rs nFFdCfd3vDxynTyXH2mlOuWcqCJ44t0+3G6kdLTvhTbfm6XO4L3aRgLNbIFmLPs8sCcU RoUDQI+gb3RraMXv9uwEPA3wGMwdy5fzgiHJs5fCer51B7+T1Qvk0bdJ3qnUMPN6Ul6M qQbFmVkTqESidQInim3P5vXTLsnNQe4XdDTxHR2YuqWOPR5XJsT1+ss2WJeNwNJIUrzL dsjmVmDlFOHaD5AWSET/M+F73xWO75jC/BhDymOoDIMd1BqMBJGCk86+pH5hffswE3VG /BHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iUblFBDSbSYaBc0dVFljstq0lO5uBzNiwyO+b0dk7GI=; b=TkoZINZ8W5D3p1myGMrBHezq5W3QjMaOlO36DYaCSn1e4UDWN0ukLOJu+Q37/cYa98 p2aheCTpCloBDMXErzpQYK0nhCzQJMTi+zNvr1hKtOpUASg6zj7pys+J54JPJdbIQblt n43xa5qfnR9PpGC8iFFPfSV/WTOo2BnsV94u963TTno3tgISp8VFsc+ASU4tJhtjCiKe /HPA19QiEyMMTQbxgEZy7l6HIcsdaIRDpKkyyFUz951rtwmXSWYy0yuofuBwSzRhVcof 7lEE3sGty+DZwFkwi/G6dYOpcZze1pQbd/EbIbo8cmmPo6RYrf+0NoBVJchS8Byfaqnh 1gOw== X-Gm-Message-State: AOAM533WcKNvws1bOSklRsuTvUdwaap3CdQoBIREoypICK5v4q9GYa1d ocS7ZLLtQFvFlTCqr6mbbATwv/YvaX53vQ== X-Google-Smtp-Source: ABdhPJxQiGw4b/Yw/ZkNTtJtaWPQD3qvnuJkpYPxc/qtKgLWlcit2QkdoxBy+OILTuIdu1sgin5ouw== X-Received: by 2002:a1c:6a0e:: with SMTP id f14mr4352245wmc.114.1621334975677; Tue, 18 May 2021 03:49:35 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id f8sm16428089wmg.43.2021.05.18.03.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 03:49:35 -0700 (PDT) In-Reply-To: (Paul W. Rankin" via "Emacs development discussions.'s message of "Tue, 18 May 2021 18:17:04 +1000") Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269440 Archived-At: "Paul W. Rankin" via "Emacs development discussions." writes: > On 2021-05-18 16:58, Karl Fogel wrote: >> On 18 May 2021, Paul W. Rankin" via "Emacs development discussions. wrote: >>> Ugh. Not sure how this slipped into master but it is not a >>> good/considerate idea to set default value of bookmark-fontify to t. >>> If there are no reasonable objections I'll push this later today. >> I don't have a strong opinion either way, but if you're curious as to >> where this came from, it was here: >> The discussion in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179 >> is quite long, so it might be worth reading before reverting. > > Hi Karl, > > The discussion there only seems to account for compatibility with package bm.el, > not the more general "avoid pushing your idea onto everyone" idea. And given the The discussion there also raises concerns about some unintended consequences of the new feature, such as with Org refile/capture[1] or when overwriting an existing bookmark[2]. [1] https://bugs.gnu.org/48179#63 [2] https://bugs.gnu.org/48179#60 So I suggest you chime in there. > overlay is temporary, it's quite opaque for the average person to inspect it to > see what's actually happening. It's so ugly my first thought was that something > had broken rather than this was actually an intentional feature. > > I'm going to commit this without further discussion -- which hopefully should > remind others to take the more considerate route when introducing new features! -- Basil