From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Mon, 24 May 2021 02:35:19 +0300 Organization: LINKOV.NET Message-ID: <87eedxrqz4.fsf@mail.linkov.net> References: <87zgwlb4xc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13756"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Daniel Mendler , monnier@iro.umontreal.ca, emacs-devel@gnu.org To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 01:49:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkxqd-0003V0-1E for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 01:49:31 +0200 Original-Received: from localhost ([::1]:43076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkxqc-0004k0-3T for ged-emacs-devel@m.gmane-mx.org; Sun, 23 May 2021 19:49:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkxpi-0003Pc-9o for emacs-devel@gnu.org; Sun, 23 May 2021 19:48:34 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:49445) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkxpf-0006PY-3N for emacs-devel@gnu.org; Sun, 23 May 2021 19:48:34 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 40D7BE0002; Sun, 23 May 2021 23:48:24 +0000 (UTC) In-Reply-To: <87zgwlb4xc.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Sun, 23 May 2021 20:55:59 +0100") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269721 Archived-At: > I also don't understand why :affixation-function is given a full list of > completions, when it is presumably meant to return a list of exactly the > same length. This has the advantage in functions like read-extended-command--affixation, where minibuffer-selected-window is selected only once with with-selected-window, then all completions are processed in the same buffer, without the need to switch buffers for every completion in a long list, as annotation-function would require to do. > Seems like a potential hazard to allow this function to do filtering. OTOH, not allowing the function to do filtering is too much hand-holding for users who want the freedom to transform the completions to their likings.