From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Luke Lee Newsgroups: gmane.emacs.devel Subject: Re: master 87e7390: * lisp/progmodes/hideif.el: update for new C++ standards and extensions Date: Thu, 03 Jun 2021 11:19:17 +0800 Message-ID: <87eedjtz2i.fsf@lukehome> References: <20210602123045.16251.72470@vcs0.savannah.gnu.org> <20210602123047.2969E209AA@vcs0.savannah.gnu.org> <87lf7sguqd.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11386"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 03 05:20:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loduP-0002hJ-DI for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Jun 2021 05:20:37 +0200 Original-Received: from localhost ([::1]:59088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loduO-0007CY-9Y for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 23:20:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lodtE-0006VQ-9R for emacs-devel@gnu.org; Wed, 02 Jun 2021 23:19:24 -0400 Original-Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:33409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lodtC-00017d-Sa for emacs-devel@gnu.org; Wed, 02 Jun 2021 23:19:24 -0400 Original-Received: by mail-pg1-x536.google.com with SMTP id i5so4079272pgm.0 for ; Wed, 02 Jun 2021 20:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+nWnEyl6pnb7z8J2ZKSRlaBSju+8Thi3jqqIbrzIhT4=; b=dl+rA26HCezms4qDyOqJk8j+kBmyFQolQTI68T2bF0uDh+dPKI7payXDO2KGRctTDa ouyhr3zAmip8nhXGlwfgK5Q4sEAbSprJuDv3N8FjrTOtlZaCScFloaYVI7upTQ7I2avg gtH1NtSDDkbFfEpXfskZEVK32DH7hO/qUr5AqiAvGkjyRUbJXzB8QASEyU5zPrv3Xg4x wAzsb8HfZu/ZftA8YVS4t2BFmti2rFJWkohwwXnEJ4E79Hb2P/INFtk93NR5l1KRoLBJ wEOWP41c/Sr5ffghd5VP7PBThhMvQ+ZeaJSH4YV05PHQLRLbLVcpJU3MkNWh8cNq/Swf egUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+nWnEyl6pnb7z8J2ZKSRlaBSju+8Thi3jqqIbrzIhT4=; b=tbxzlxA3p7BF9/JMRr5xmA/f5dOsmLx0G1hx8gOsnw0YI80/9RZwTO8h/johWRis6g N1BRnmi51fZyvBehrhH7BHi3ZCYgumryZJ/hlLGwA0SFCA4u+27Ey7ZoxxFRuFRwdSWv DOm/5ceRSSJOYOzEh1EN/1OKKprCmC25pivV2mo58e3yh+pO3sZ7UJUkdxO57m/KsjHe grRGvk7JtkwzL+7/ymLtWyiU9RGWXps/JmFL4rV1Y4JUNZgl0qvZuKWrXJWumYD7fo1D IjT1ZaXPlwonKfvJh57F/MTwnorKL72Klq+zXPUmFFGIjWUMlhEmYJ9q1HWhjJ4iwF/p KYSg== X-Gm-Message-State: AOAM533ZwX2DX9BILkPB6Dj6PAnlovNLP37KodUhIxJfvoADZFqQx+CY MXUoCIazz1GE+cWjqnZ96+OxkbJUCvW6uw== X-Google-Smtp-Source: ABdhPJyhMTFSRq9I/exWFtD2TKEowkEA96KwfVptrqx7Q2IJj/llfkhdU2/8E2UR6JmGGGj0moATig== X-Received: by 2002:a05:6a00:1a0f:b029:2dd:823b:3dce with SMTP id g15-20020a056a001a0fb02902dd823b3dcemr30089638pfv.35.1622690360561; Wed, 02 Jun 2021 20:19:20 -0700 (PDT) Original-Received: from lukehome (2001-b011-3815-56eb-30d9-cafd-0b28-59c2.dynamic-ip6.hinet.net. [2001:b011:3815:56eb:30d9:cafd:b28:59c2]) by smtp.gmail.com with ESMTPSA id t23sm1050764pgj.9.2021.06.02.20.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 20:19:19 -0700 (PDT) In-Reply-To: <87lf7sguqd.fsf@tcd.ie> (Basil L. Contovounesios's message of "Wed, 02 Jun 2021 16:19:06 +0100") Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=luke.yx.lee@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270332 Archived-At: >Does this need a define-obsolete-variable-alias for backward >compatibility? You're right, I will add that in my next patch. >> +(defcustom hide-ifdef-evalulate-leave-hook nil >> + "Hook function to be called when leaving `hif-evaluate-macro'." >> + :type 'hook >> + :version "27.2") > >Should these :versions be "28.1"? I originally planned to add it into emacs-27 branch but later found in the contibution guide that 27.2 indicates a feature freeze branch. Is there any way (or is it okay) to add it to emacs-27, if there is an up-coming 27.3? Or should I just leave it here in 28.1? Thanks. Best regards, Luke Lee