From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Highlight current line when using gud Date: Fri, 02 Jul 2021 13:01:38 +0200 Message-ID: <87eechvv1p.fsf@gnus.org> References: <46933061-DFBC-406C-8489-F3DC7EE770BA@kuaishou.com> <87sg0z8t5t.fsf@gnus.org> <6F39630A-1FF8-45DE-9E3B-D9E8BE906BD7@kuaishou.com> <83o8bnmqyo.fsf@gnu.org> <62662FDA-8D67-459B-8F03-662010FB96EB@kuaishou.com> <87y2aq1dhm.fsf@gnus.org> <87zgv5dh80.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Zhiwei Chen , "emacs-devel@gnu.org" To: Zhiwei Chen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 02 13:03:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzGws-00058O-Sr for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Jul 2021 13:03:06 +0200 Original-Received: from localhost ([::1]:52710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzGwr-0007Kh-T9 for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Jul 2021 07:03:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzGvb-0005el-JX for emacs-devel@gnu.org; Fri, 02 Jul 2021 07:01:48 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzGvY-0006Dx-R8; Fri, 02 Jul 2021 07:01:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=X244ZwjnUv+Ng8jZzaywHnow3hfAwcGsUeMYSOo5oLA=; b=BNm/l0xFFdRPEhY47Tfs5gnB12 HAaB7PcH1pk5KCisHJISH7ASveJrFl54ktPbXPqn4NB3H/zHbWHqD1qu9tyRKfaMWpICkYpSJ5hRY x3d9p5mSG1Jz48HAFLGnE3xCrP5g+eYJjvch62xNTilx6Pnpk/imHalfwhvBPi51olDM=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzGvT-0007wh-2J; Fri, 02 Jul 2021 13:01:41 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWgemXUx7FTSD// //+Tufv2AAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UHAgo6CLSR55cAAAF1SURBVCjPPZE9TgMxEIWf rbUUXAVkU0eIItpTLCgrAdWCPIiSlls4UWhSUUBvRSBZc0pmvAFri/n85ueNF2jHuJuEUYJri3Vx lOBmAd0mxDsNoqaNEQvI5wwGUCS/lVtrNh9TILKSYm0OSzdMAImSzWbAlIDUhozBvSWYJ2gLMzlM cA+q7AHXSVePNWzwMrx2YORTYXm2jNLsaJ1nMOcGbuoFam5iHLiIwg3olrfohQDvqGeHW27HJS5R 3LUW+YK3hNRn/iJaeXYTXqQqBGKu5wNeC2wkKc+jVTuINMr4tMYSXpWrsrz80XleAB3Rl7wBuOwy jN7s4ZsfRwJZWhcjMArgyMe6MbPixWk1nW0gziqb9Ae72ss0zHDgHl5tCGTZJtvFrBza4mfnCjuJ j8WpAWpvUGo0NDeQuMbxD2rvT6Dk7VJqHkms8Q6HcCNCUqFHfb//r7Hf5ay1lrSj/dRF01xzIMic FDQt14DVqIr+BHmDlQ76BcC8mx4Ms7DKAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA3LTAyVDEw OjU4OjA4KzAwOjAwGkrvvQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNy0wMlQxMDo1ODowOCsw MDowMGsXVwEAAAAASUVORK5CYII= X-Now-Playing: Kinematik's _The Wire Tapper 52_: "Al-Qulub Al-Mughallafa Bet-Turab La Tankaser" In-Reply-To: <87zgv5dh80.fsf@gmail.com> (Zhiwei Chen's message of "Fri, 02 Jul 2021 02:25:19 +0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271100 Archived-At: Zhiwei Chen writes: > Why do I introduce a new overlay in gud buffer? Because it's used to > show the line where the debugger stops at. The position of the gud > overlay is controlled by the debugger, not by users. So using > hl-line-mode in such a situation is not the proper way. Hm, I see... I rarely use gud, and I never use any line-based highlighting, so I don't really have any opinion about this. Anybody else? Looking at the patch, it looks good to me, but I wonder whether the `gud-overlay-line' variable should be buffer-local in case there's more than one gud buffer? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no