From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] memory-report: support calculating size for structures Date: Sun, 29 Aug 2021 21:11:36 +0200 Message-ID: <87eeacf4lz.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24863"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Yikai Zhao" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 29 21:13:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKQFK-0006Fa-Gi for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Aug 2021 21:13:34 +0200 Original-Received: from localhost ([::1]:33708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKQFI-0006Ia-PY for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Aug 2021 15:13:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKQDY-0004p8-Fe for emacs-devel@gnu.org; Sun, 29 Aug 2021 15:11:44 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:45018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKQDX-0005PW-1y for emacs-devel@gnu.org; Sun, 29 Aug 2021 15:11:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QXWIVrBaBIEjsYJ2XXO+CqAF5D/siVub+8aPMXgB2M0=; b=gva0VXHR/PgiuS0QGAgxNx/Au6 Y5Jg+vESHcrTrD/+9TQFqA6Lu/ZuzQ+JVJex+4SoyyM1GZbdq4w9DMucj3VNdBy/UcRlmjfTOYNdo 52pW2C7R0KP/OJaFoeJJ2pZ/4HMUlY5ovhHcJAUyh9wDSbWQWrYpWWxg/PqfwMh2DHdk=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKQDQ-0002oD-LW; Sun, 29 Aug 2021 21:11:41 +0200 In-Reply-To: (Yikai Zhao's message of "Sun, 29 Aug 2021 22:40:48 +0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273430 Archived-At: "Yikai Zhao" writes: > Here's another patch on memory-report package which fixes the object > size calculation for structures (cl-defstruct types). Before this > patch, memory-report--object-size will report empty size for structure > objects, which results in incorrect report about "Largest Variables" > in memory-report result. Thanks; looks good. > Regarding the copyright assignment, I'm currently in the progress of > signing it. But maybe this patch is small enough to apply without it? In itself, it would be small enough, but with the previous patch, it pushes it above the limit. So after the assignment process is complete, can you remind us to apply the patch. (And perhaps put the patch into the issue tracker with `M-x submit-emacs-patch' so that it's not forgotten.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no