unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Yikai Zhao" <yikai@z1k.dev>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] memory-report: support calculating size for structures
Date: Sun, 29 Aug 2021 21:11:36 +0200	[thread overview]
Message-ID: <87eeacf4lz.fsf@gnus.org> (raw)
In-Reply-To: <ef1a8d35-e43f-4495-a458-d48460fb3e83@www.fastmail.com> (Yikai Zhao's message of "Sun, 29 Aug 2021 22:40:48 +0800")

"Yikai Zhao" <yikai@z1k.dev> writes:

> Here's another patch on memory-report package which fixes the object
> size calculation for structures (cl-defstruct types). Before this
> patch, memory-report--object-size will report empty size for structure
> objects, which results in incorrect report about "Largest Variables"
> in memory-report result.

Thanks; looks good.

> Regarding the copyright assignment, I'm currently in the progress of
> signing it. But maybe this patch is small enough to apply without it?

In itself, it would be small enough, but with the previous patch, it
pushes it above the limit.  So after the assignment process is complete,
can you remind us to apply the patch.  (And perhaps put the patch into
the issue tracker with `M-x submit-emacs-patch' so that it's not
forgotten.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2021-08-29 19:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 14:40 [PATCH] memory-report: support calculating size for structures Yikai Zhao
2021-08-29 19:11 ` Lars Ingebrigtsen [this message]
2021-08-31 16:15   ` Yikai Zhao
2021-08-31 16:27     ` Eli Zaretskii
2021-09-01 15:23       ` Yikai Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeacf4lz.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=yikai@z1k.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).