From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Patch proposal: display symbol source code in help buffers Date: Tue, 21 Sep 2021 18:49:49 +0200 Message-ID: <87ee9h27rm.fsf@gnus.org> References: <875yuvlrz3.fsf@gnus.org> <87r1djixiw.fsf@gnus.org> <878rzrzpfz.fsf@localhost> <87zgs7y5wc.fsf@localhost> <87sfxyftrw.fsf@gnus.org> <87mto6ifd2.fsf@localhost> <83r1diz5k9.fsf@gnu.org> <87r1diqodc.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25283"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , Stefan Kangas , arthur.miller@live.com, emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 21 18:51:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSizJ-0006E6-FZ for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 18:51:21 +0200 Original-Received: from localhost ([::1]:38586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSizH-0005NR-Mh for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 12:51:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSixx-0004VS-27 for emacs-devel@gnu.org; Tue, 21 Sep 2021 12:49:57 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:35704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSixv-0000D0-Hl; Tue, 21 Sep 2021 12:49:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Oa2Wqu5diSjHfFnLAt4cj5Eut7IqEy3hkeNF/AzZor4=; b=Rk8NJFi541liJJLwpb7kqH54Cw zE1rYwAjwZ24D1HUbRcD379aX40wUo5ABvMlHycqMbf3vfKv/mV+u24NuPTjbId0lHu6FFM1t9/8q dpltptCx8va+xvVuiiOR0CJL1F9P4cBxjdc5Xwo90WV7jOfd6KdQii+eEr1oOiQeFu3o=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSixp-00086d-OQ; Tue, 21 Sep 2021 18:49:52 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEUsKCaCaWfc2db/ //99QFzzAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UJFRAuLbJ0E2QAAADfSURBVCjPldE9DoJAEAXg kcgWVBRYuEfgFJiINSbQWNswp9DCfgtDQYUJGHmnFMP+aWKiW+2XzbyZzBL9ccK8dEj2VWax2mwc qCQPYVY4yKsXx+MXlAwXUPPdgTnXDauCJMMDvJoAw3yJq5LWeMwoJtTcZPqNFuCmwcmU7C7CQOCs BMzMUCT0dEHrIcILOjxFqyjq9ZhoOpLKYDhSms3THTAWxDr5AMQEh2Qx0lL3RBKYjQhga3pOQ+MS Pew+cJO9QYqBLSRGWEwJUHY78Ff1sTf/S97gkl9FnQeh6PfzBJ1CT4GD8YKeAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIxLTA5LTIxVDE2OjQ2OjQ0KzAwOjAwT4uJPgAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMS0wOS0yMVQxNjo0Njo0NCswMDowMD7WMYIAAAAASUVORK5CYII= X-Now-Playing: David Bowie's _Brilliant Live Adventures (1): Ouvrez Le Chien (live Dallas '95)_: "I Have Not Been To Oxford Town" In-Reply-To: <87r1diqodc.fsf@localhost> (Ihor Radchenko's message of "Tue, 21 Sep 2021 17:17:19 +0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275251 Archived-At: Ihor Radchenko writes: > Agree. I updated the patch and also added support for > widen-automatically variable. See below. [...] > diff --git a/lisp/help-mode.el b/lisp/help-mode.el > index 551cf7e1a3..57655db337 100644 > --- a/lisp/help-mode.el > +++ b/lisp/help-mode.el > @@ -268,6 +268,7 @@ help-function-def--button-function > (when (or (< position (point-min)) > (> position (point-max))) > (widen)) > + (push-mark nil t) I was thinking something slightly more subtle. That is, if we've just opened the file (i.e., it has not been displayed before), we should not push the mark. And if point didn't move, we shouldn't push the mark either, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no