From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: native-comp-async-report-warnings-errors default value Date: Wed, 08 Dec 2021 10:19:59 +0100 Message-ID: <87ee6nqwqo.fsf@gmail.com> References: <87h7dj7su7.fsf@gmail.com> <83r1cnlu6y.fsf@gnu.org> <87czo77rx7.fsf@gmail.com> <837dcmamt2.fsf@gnu.org> <83v90694ka.fsf@gnu.org> <83v901zdh6.fsf@gnu.org> <8735n4hmyn.fsf@gnus.org> <878rwwhhu6.fsf@gmail.com> <87wnkgfv4m.fsf@gmail.com> <8335n4zdyx.fsf@gnu.org> <87wnkgl5ie.fsf@gmail.com> <83tufkxrmn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26150"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org, stefankangas@gmail.com, akrl@sdf.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 08 10:21:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mut8P-0006Yb-FO for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Dec 2021 10:21:09 +0100 Original-Received: from localhost ([::1]:51040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mut8O-000186-1D for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Dec 2021 04:21:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mut7L-0000Kk-Pd for emacs-devel@gnu.org; Wed, 08 Dec 2021 04:20:03 -0500 Original-Received: from [2a00:1450:4864:20::436] (port=44685 helo=mail-wr1-x436.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mut7K-0003LD-Ec; Wed, 08 Dec 2021 04:20:03 -0500 Original-Received: by mail-wr1-x436.google.com with SMTP id t18so2845449wrg.11; Wed, 08 Dec 2021 01:20:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:message-id:mime-version :content-transfer-encoding; bh=cVsJ+nmehapG4I2kwvddvyO8eppKcg06FLFbjctzcqw=; b=AOQh0IwxfHixU3zIzHRAyIQbMiX9haPM5C8nOZu71b4RVsB/mf9oWX/UX+E5vnRpbo aVATCKE4awnHAOZS8Lc/E1vJfHdeKpIR9Ol5iisUCPPdRzSm9tg6V/5SG2uGW9xjxBIa oJMj7OR/uCEz+DM2oPbhghiUqLZ9TpaXH6JELYDt46cctCBeZajlTOxJWIpjrAiYkdIV k/X8bbS6UcLvDZHA6uCKXCqaPkPd2HhzL7YP143h46Jvh4Myzk1I1hTXl3gGfRAWhMbk Eddonxl8tek4mVFt1dUD+S+NdNFZRxRJoh5+T0ui7WXk1sUk1bmQuJyKBEX3EtLGqqjs yzKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version:content-transfer-encoding; bh=cVsJ+nmehapG4I2kwvddvyO8eppKcg06FLFbjctzcqw=; b=DbAeUKaeJitZLkhzI9krrm0QtUEjMSmZ4tC7RpQz2ObjEgjE8/79hdngt5GtLH3G78 cLYMBTlfJJ0mOuKjFJNsqkyZQVMdBGMylNzGIl75zjXntp1xphGrsS+e2sGXbAGC8cE3 vuAKvf0j51lXMeXETX658boWRUOhHY6KN6zCP56s/gXg6z19mVOtbOq8ricJmLZv92Eb IfRU/h4MmCFHK6s0Uw7HXIjQ6wmC7CG9h18eTJYuyMFhgrOIirQm4JWmmyFok44o54zM UH/KN3ZOjyCBIgXyMey2tT6McMzLSNNRvM5Y0rrGJLWKmmyO+3Y//HA+j2rNhslDa5mc YeFg== X-Gm-Message-State: AOAM531vgPkyuk2SaNWHlcLCWQPUTqMsAqLir0cJUuT/zg8fbmD8YaMv D67T2xJMJzkcu8CLufjkz1eS5UFzRjM= X-Google-Smtp-Source: ABdhPJzXAlOF0/aoREsBa6Pe6ooVU2HH/4zfnIYsfuFPruIjOMs6Jr5ICP47qaE1qK42RNJqqEZhhg== X-Received: by 2002:a5d:54c5:: with SMTP id x5mr55356664wrv.607.1638955200423; Wed, 08 Dec 2021 01:20:00 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:e06b:fb08:141a:5ed3]) by smtp.gmail.com with ESMTPSA id d188sm5635079wmd.3.2021.12.08.01.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 01:19:59 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::436 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=rpluim@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281329 Archived-At: >>>>> On Tue, 07 Dec 2021 19:16:16 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: akrl@sdf.org, larsi@gnus.org, stefankangas@gmail.com, >> emacs-devel@gnu.org >> Date: Tue, 07 Dec 2021 17:54:49 +0100 >>=20 >> Let the wordsmithing begin! Eli> Thanks, this is fine, with two gotchas: >> +is available. Note that because of this use of a subprocess, native >> +compilation may produce warning and errors which byte-compilation d= oes >> +not, and lisp code may thus need to be modified to work correctly. = See Eli> = ^^ Eli> Two spaces there, please. >> +@code{native-comp-async-report-warnings-errors} in @xref{Native-Com= pilation Eli> @xref is inappropriate in the middle of a sentence, since it produ= ces Eli> a capitalized "See". You want @pxref instead. Fixed and pushed to emacs-28. >> I guess we could add a link to >> `native-comp-async-report-warnings-errors' when the warning type =3D= =3D (comp) Eli> We could, yes. Assuming the code to add that is simple enough to Eli> install on the release branch. Something like this, although this puts the button on all warnings, not just the ones about missing definitions. And now I=CA=BCm tempted to *remove* the 'Disable' buttons for 'comp' warnings, since clicking those will suppress all native compilation warnings. diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index 36b275e2d3..8aa6d18d61 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -298,6 +298,12 @@ display-warning ;; Don't output the buttons when doing batch compilation ;; and similar. (unless (or noninteractive (eq type 'bytecomp)) + (when (eq type 'comp) + (insert " ") + (insert-button "More Info" + 'help-echo "mouse-2, RET: Show native-com= pile documentation" + 'action (lambda (_) + (describe-variable 'native-comp= -async-report-warnings-errors)))) (insert " ") (insert-button "Disable showing" 'type 'warning-suppress-warning (I really must either update some packages or hassle their authors. I=CA=BCm getting like 200 warnings) Robert --=20