From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 262a7c9ea0: New minor mode elide-head-mode Date: Sun, 09 Jan 2022 18:22:37 +0800 Message-ID: <87ee5htdhu.fsf@yahoo.com> References: <164172314114.31544.13495331125988316383@vcs2.savannah.gnu.org> <20220109101221.E3FDAC0DA16@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Stefan Kangas To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 09 11:23:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6VMI-000AM3-W9 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 11:23:31 +0100 Original-Received: from localhost ([::1]:51438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6VMH-0004kQ-F6 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jan 2022 05:23:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6VLh-00044u-2V for emacs-devel@gnu.org; Sun, 09 Jan 2022 05:22:53 -0500 Original-Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:36089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6VLe-0005Zi-Qc for emacs-devel@gnu.org; Sun, 09 Jan 2022 05:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641723767; bh=NI3QKZ9dF2xxwipf3x6QHv9qbm7bKAXFRMahq+rQdw4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=WvpgVSpOgO5DlEwDmYfX2ZES2a5hOufsx8wWAaA0BKlQHmG2r+kzrw88yvSVw2PvJWtZs85qbqq60pJzO4kYzAYF2GAi+zwVLn9T7K7CyF86yK5ctEr/Te6QXJjphXnUWpoD1tkCiRiXQ9SSM72MGnlPkIkv2auoEunYH+sLPo6TfN0ePvYHgCkZVXSn14FOPxi4mUuV79w6KeRniBdt7oqvmanlOub2PJhFsIMO81ma3feNQc8vXwrPV6bmJBUrNpAs3aF7SOncA/zEbAXDp01e0Bo/Dq7MG89SBSKz9nQf/pGUwrhvek494plWYh6XNYjTLgt445MdcwCZXypEAg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1641723767; bh=1+Ye4eSqS903ZHDyQA2R5OqeVg+CCBUknG2tcofDPqo=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XGnNncZkFWuKRAoJnp/oa9lfCylZZbbe6i3QMFXu7EcAnusNxGlz09dUNEQ0ew4LWdwZPoMXKMlqP1zCsjVQnGsxJPL8gIJiByGxrrrtbD3pkM45ECac5gpzeqbMhhUmH+s72aWICrYqHXVh689KpbTqXk+/lDvo0VBhs0VN3rCp3HqGIIKBpwp6Qw7bcWtliJ5a8bsELvDs6bqaIB16/nHpQmvTWxRZYkFGK0aXs0d8JA3+UHMgznqa+jt5x5iqaXCfYtKckjG+krOXqyB/hYswonWaBKLq/I6KQy3hp6hPWiO8ZQQXXL6C3gPFRM2caiUfzTQQxGn8cP8YV0WIlQ== X-YMail-OSG: nan.ZBUVM1mi5I99XhypzA0jKP2.BoXQb3r5O7eVJHdH9EYlL__g2IJ1o0Oc_OV Gc34HkUmv0bYgCKGqUN2YED17yFbGoO9ZKQiYoMx468B9EGkD9SmtA8UVk4JYmYLyvBLdv8xFRxD zaRGIVmCV4GZEE_Yr.AG2lFl.QJszArTXcnV_Q2aBeU6X2xvdeOIC4V0L_6VsDeyDwsdRDZVHtpc NHdHxQxzKn7AlFDUXkfMt7uJo.Zkf6OsNJl_OWNUxqccVImhjQzHeRepqV37FMmKdAVbiGFkuFxR ZfB1EA1YY5dQpe8h6L0rRepPrGGUAHsZ4S7kS91CS99DSKRDyBYqQ6eAyugrQpPwcIdGrgs9SiTP JlCzEnVvRA5Ks1gnE6LAFKGLlbVYKhWl.dmmuLIcXmUc0artIPi5ovfW04xs745Ttoy7anRSuyFl MrzP9On5jd0VWfSAHoHGkyWdZJtUtdY3f3JQkwQUV2OWCrgUIKzj8rNeFzXPEBDdr8F4HttGJkfo Pk5NCxeg4ibDe1wMXUsXO7_V_Kr8ZdrkUd6K01E837fBMd7a6b3WbqvxxQqbILqTM96LewmOkRkT vzAPaoJf23yKredRAUNlT_YzP6tRCdWjGuxWUWZp8HBqmtolUDbcwZ2CnQZdNVgiZqrmpWOWske6 m5fk5ILfGvJJ5718gRcCWaJSil29oETGrElrdvJqAhrh8xsN4p.Qd3gzZ3IOEvHFRGEUajma40dk FyjPhG1jBXGiPtmt8q2lEc7fH4xc2Y0C359JpQ3K0QhFKu9tJJmTCmkYAyj3cdeS5h1q2NfQ3jWh wfvZfJG7Fep1W5ThKcGwhqIPpGK8cqz7fLWmy_8jfr X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Sun, 9 Jan 2022 10:22:47 +0000 Original-Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d65e4eafcb8c26d0f1264e216543f2f8; Sun, 09 Jan 2022 10:22:42 +0000 (UTC) In-Reply-To: <20220109101221.E3FDAC0DA16@vcs2.savannah.gnu.org> (Stefan Kangas's message of "Sun, 9 Jan 2022 05:12:21 -0500 (EST)") X-Mailer: WebService/1.1.19551 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.187.31; envelope-from=luangruo@yahoo.com; helo=sonic308-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284499 Archived-At: Stefan Kangas writes: > (defun elide-head (&optional arg) > "Hide header material in buffer according to `elide-head-headers-to-hide'. > @@ -88,43 +151,17 @@ The header is made invisible with an overlay. With a prefix arg, show > an elided material again. > > This is suitable as an entry on `find-file-hook' or appropriate mode hooks." > + (declare (obsolete elide-head-mode "29.1")) > (interactive "P") > (if arg > - (elide-head-show) > - (save-excursion > - (save-restriction > - (let ((rest elide-head-headers-to-hide) > - beg end) > - (widen) > - (goto-char (point-min)) > - (while rest > - (save-excursion > - (when (re-search-forward (caar rest) nil t) > - (setq beg (point)) > - (when (re-search-forward (cdar rest) nil t) > - (setq end (point-marker) > - rest nil)))) > - (if rest (setq rest (cdr rest)))) > - (if (not (and beg end)) > - (if (called-interactively-p 'interactive) > - (message "No header found")) > - (goto-char beg) > - (end-of-line) > - (if (overlayp elide-head-overlay) > - (move-overlay elide-head-overlay (point-marker) end) > - (setq elide-head-overlay (make-overlay (point-marker) end))) > - (overlay-put elide-head-overlay 'invisible t) > - (overlay-put elide-head-overlay 'evaporate t) > - (overlay-put elide-head-overlay 'after-string "..."))))))) > + (elide-head--show) > + (elide-head--hide))) > > (defun elide-head-show () > "Show a header in the current buffer elided by \\[elide-head]." > + (declare (obsolete elide-head-mode "29.1")) > (interactive) > - (if (and (overlayp elide-head-overlay) > - (overlay-buffer elide-head-overlay)) > - (delete-overlay elide-head-overlay) > - (if (called-interactively-p 'interactive) > - (message "No header hidden")))) > + (elide-head--show)) Hmm... couldn't those two obsolete commands be made wrappers around `elide-head-mode'? For example: (defun elide-head-show () "Show a header in the current buffer elided by \\[elide-head]." (interactive) (elide-head-mode 0)) And if those commands are made such simple wrappers, they could be un-obsoleted as well, since it would be useful to explictly disable or enable elide-head-mode inside `find-file-hook' and other similar places. Thanks.