unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 02bca34: Utilize new string decoding feature in GTK native input
Date: Sat, 19 Feb 2022 20:49:58 +0800	[thread overview]
Message-ID: <87ee3zm361.fsf@yahoo.com> (raw)
In-Reply-To: <838ru7yqw4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Feb 2022 14:36:43 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> You can still explain that in a comment to the code.

Thanks, will do.

> And what do we want to do with those invalid UTF-8 sequences?  The way
> you did it will produce raw bytes for them -- is that really TRT in
> this case?

Yes, it'll alert the user that something has gone wrong with the input
method.

> In any case, at the very least consider using decode_string_utf_8
> instead of consing a Lisp string and then using the "usual" decoding
> stuff -- decode_string_utf_8 will cons only one string.

I will look into that.



      reply	other threads:[~2022-02-19 12:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19  9:35 master 02bca34: Utilize new string decoding feature in GTK native input Eli Zaretskii
2022-02-19 10:09 ` Po Lu
2022-02-19 12:36   ` Eli Zaretskii
2022-02-19 12:49     ` Po Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee3zm361.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).